Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Welcome to lichess.org" email - add links #5454

Open
superuser-does opened this issue Aug 24, 2019 · 6 comments
Open

"Welcome to lichess.org" email - add links #5454

superuser-does opened this issue Aug 24, 2019 · 6 comments
Labels
improvement Small incremental improvement to an existing feature

Comments

@superuser-does
Copy link
Collaborator

A tiny thing: currently, we send an HTML email for email confirmations with a nice URL to click on.

There's a welcome email sent after you verify your email that has URLs in it to your newly registered profile. They're not actually hyperlinked, so ProtonMail for example will just leave them unlinked.

The welcome email currently reads:

You have successfully created your account on https://lichess.org.

Here is your profile page: https://lichess.org/@/Patzer. You can personalise it on https://lichess.org/account/profile.
 
Have fun, and may your pieces always find their way to your opponent's king!

Would be great if the three URLs there were also hyperlinked so they're clickable for dumb mail clients!

@superuser-does superuser-does added improvement Small incremental improvement to an existing feature good first issue Narrow in scope (but not necessarily easy) labels Aug 24, 2019
@jgonzalez1
Copy link

I will try and take this

@chace86
Copy link

chace86 commented Oct 10, 2019

Is this being worked? I would like to give it a try otherwise.

@jgonzalez1
Copy link

jgonzalez1 commented Oct 10, 2019 via email

@superuser-does
Copy link
Collaborator Author

You might be able to take a cue from the way the URL is done here for the confirmation email: https://github.com/ornicar/lila/blob/master/modules/security/src/main/EmailConfirm.scala

Not sure what Mailgun actually outputs that to, and don't know how to test it myself, I'm not a programmer.

For this one, I recommend including it in a new localised string with string substitution (so put a few %1$s etc in the new i18n key).

@ornicar
Copy link
Collaborator

ornicar commented Nov 25, 2019

#5677

@ornicar ornicar closed this as completed Nov 25, 2019
@niklasf niklasf reopened this Nov 27, 2019
@niklasf niklasf removed the good first issue Narrow in scope (but not necessarily easy) label Nov 27, 2019
@stale
Copy link

stale bot commented Jan 3, 2022

There has been no activity on this issue for 2 years. It will be automatically closed in 2 weeks.
If the issue is still relevant, please briefly explain (or remove the label). Feel free to reopen at any time.

@stale stale bot added the stale label Jan 3, 2022
@niklasf niklasf removed the stale label Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Small incremental improvement to an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants