Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing movetime for last move #5543

Open
niklasf opened this issue Sep 23, 2019 · 2 comments
Open

missing movetime for last move #5543

niklasf opened this issue Sep 23, 2019 · 2 comments
Labels
bug wanted Dead or alive. Backed by a regular contributor.

Comments

@niklasf
Copy link
Member

niklasf commented Sep 23, 2019

cc @lakinwecker

@niklasf niklasf added the bug label Sep 23, 2019
@niklasf niklasf added this to bugs in Clock Storage v2 Nov 4, 2019
@lakinwecker lakinwecker self-assigned this Dec 28, 2019
@lakinwecker lakinwecker added the wanted Dead or alive. Backed by a regular contributor. label Dec 28, 2019
@lakinwecker lakinwecker removed their assignment Dec 28, 2019
niklasf added a commit that referenced this issue Mar 6, 2020
@niklasf niklasf added this to the Clock Storage v2 milestone Jun 5, 2020
@niklasf
Copy link
Member Author

niklasf commented Oct 15, 2020

Penultimate move is displayed as expected: Clocks next to board and data point in the move time graph (the second one).

image

Final move is missing clocks next to board and data point in move time graph:

image

This appears to be not only a display issue, i.e., the last move time is also missing on the server side (as seen in 8b5ba4b). Relevant server side code is around here: https://github.com/ornicar/lila/blob/9f9ec401fcd24360f6146b17a9f8e9542478e45d/modules/game/src/main/Game.scala#L148

I expect this will be a challenging issue to track down and solve.

@gobbedy
Copy link

gobbedy commented Apr 2, 2021

Hello, is this still an issue? And if so, is there a known way to reproduce it?

If there was a known way to reproduce, I could see this as a good first issue for me. I suspect given the description as a "challenging issue to track down" that perhaps there's no known way to reproduce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug wanted Dead or alive. Backed by a regular contributor.
Projects
No open projects
Development

No branches or pull requests

3 participants