Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider switching from javascript object literals to json #5644

Open
niklasf opened this issue Nov 11, 2019 · 3 comments
Open

consider switching from javascript object literals to json #5644

niklasf opened this issue Nov 11, 2019 · 3 comments
Labels
chore

Comments

@niklasf
Copy link
Member

niklasf commented Nov 11, 2019

For better performance with large objects and simplified (safe) serialization:
https://v8.dev/blog/cost-of-javascript-2019#json
@niklasf niklasf added the chore label Nov 11, 2019
ornicar added a commit that referenced this issue Nov 12, 2019
@ornicar
JSON.parse lobby data - for #5644
b32585c
@greg-finley
Copy link
Contributor

A good rule of thumb is to apply this technique for objects of 10 kB or larger -- does this repo really have many that are that big?

@ornicar
Copy link
Collaborator

ornicar commented Dec 4, 2019

Maybe studies with lots of variations.

@stale
Copy link

stale bot commented Jan 3, 2022

There has been no activity on this issue for 2 years. It will be automatically closed in 2 weeks.
If the issue is still relevant, please briefly explain (or remove the label). Feel free to reopen at any time.

@stale stale bot added the stale label Jan 3, 2022
@niklasf niklasf removed the stale label Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ornicar @niklasf @greg-finley