Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stockfish sometimes won't turn on for Safari users. #5832

Closed
nojoking opened this issue Dec 28, 2019 · 4 comments
Closed

Stockfish sometimes won't turn on for Safari users. #5832

nojoking opened this issue Dec 28, 2019 · 4 comments
Labels
bug exotic browser Needs to be tested with a specific browser no scala

Comments

@nojoking
Copy link
Contributor

Various Safari users have reported the same bug. The engine button won't stay on as pictured in the gif. This happens on all pages that have the engine button. The analysis board, puzzles, etc.

https://cdn.discordapp.com/attachments/352965935809691658/658015135067275284/lichess_bug.gif

@niklasf niklasf added bug exotic browser Needs to be tested with a specific browser no scala labels Dec 28, 2019
@niklasf
Copy link
Member

niklasf commented Dec 28, 2019

Safari 12.1.2 on Mac OS Sierra (outdated) for sure (happened today), and sure at 99% with Safari on IOS 13 (so Safari 13 I think)

@niklasf niklasf added the can't reproduce Needs steps to reproduce label Dec 28, 2019
@niklasf
Copy link
Member

niklasf commented Dec 28, 2019

Failing to reproduce on Browserstack. Unlike the screen recording, the browsers even use WASM.

@niklasf
Copy link
Member

niklasf commented Dec 28, 2019

{
    "diagnosticsVersion": 4,
    "navigator": {
        "userAgent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/12.1.2 Safari/605.1.15",
        "platform": "MacIntel",
        "chrome": false,
        "is64Bit": true
    },
    "wasm": {
        "WebAssembly": "object",
        "SharedArrayBuffer": "undefined",
        "Atomics": "undefined",
        "mvp": true,
        "structuredCloning": "ok"
    },
    "pnacl": {
        "mimeType": false
    },
    "needsBoardHeightFix": true,
    "hasTouchEvents": false,
    "animate": "undefined",
    "localStorage": {
        "client-eval-enabled": "0",
        "analyse.ceval.watchdog3.pnacl": null,
        "analyse.ceval.max-depth": "21",
        "analyse.ceval.multipv": "1",
        "analyse.ceval.threads": null,
        "analyse.ceval.hash-size": null,
        "analyse.ceval.infinite": null,
        "ceval.pool.start": "1577563833753",
        "ceval.fen": "start:0.20535523733420724",
        "just-notified": null,
        "push-subscribed": null,
        "grid": "1557063616138",
        "resize-nag": "1",
        "speech.enabled": null,
        "sound-volume": null,
        "surl6": "socket.lichess.org:9029"
    },
    "serviceWorker": {
        "navigator": true,
        "permissions": false,
        "Notification": true,
        "PushManager": false,
        "fetch": "function",
        "Notification.permission": "default"
    }
}

image

@niklasf niklasf removed the can't reproduce Needs steps to reproduce label Dec 29, 2019
@niklasf
Copy link
Member

niklasf commented Dec 29, 2019

Safari violating the localStorage spec, by firing events also in the original document (but only when there are multiple tabs).

ornicar added a commit that referenced this issue Dec 29, 2019
make localStorage pubsub more robust (fixes #5832)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug exotic browser Needs to be tested with a specific browser no scala
Projects
None yet
Development

No branches or pull requests

2 participants