Add /api/study/<id>/<chapter>.pgn endpoint #12687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ornicar
added a commit
that referenced
this pull request
Apr 15, 2023
ornicar
added a commit
to benediktwerner/lila
that referenced
this pull request
Apr 16, 2023
* master: fix date parsing in mod activity aggregator scalalib 9.3.5 code tweaks fix mod activity maxDoc fix boost mod games view fix blog dates upgrade scalachess to fix UciCharPair upgrade scalalib to fix toNow New Crowdin updates (lichess-org#12683) add `status` and `winner` fields to the event stream game objects return textual error messages in PGN endpoints - after lichess-org#12687 Add /api/study/<id>/<chapter>.pgn endpoint
kraktus
added a commit
to lichess-org/api
that referenced
this pull request
Apr 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12548
Mirrored the all chapters API endpoint but I wonder if it really makes sense to return error JSON here 馃
Not doing it certainly would make things cleaner. Though I guess maybe it also just makes sense to duplicate the bit of code instead of having a fairly small function with a lot of parameters 馃