Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puzzle replay: redirect to dashboard only after voting #12759

Merged
merged 1 commit into from May 1, 2023
Merged

Puzzle replay: redirect to dashboard only after voting #12759

merged 1 commit into from May 1, 2023

Conversation

ttomczak3
Copy link
Contributor

Fixes #12717
With this fix, the redirect will only take place when the user clicks on the green "thumbs up" or red "thumbs down" icon, indicating that they have completed the puzzle.

@ornicar ornicar merged commit 67c5a57 into lichess-org:master May 1, 2023
3 checks passed
@bill-starr
Copy link

Should this change be effective now?
I am replaying some puzzles and it is still redirecting to the dashboard as soon as I successfully replay the last puzzle in a category, without waiting for me to click the thumbs-up or thumbs-down rating buttons.
For example, at the following URL, I have one to replay.
https://lichess.org/training/replay/30/kingsideAttack
As soon as I finish replaying it, it redirects to the following page.
https://lichess.org/training/dashboard/30/dashboard
I would prefer for it to wait until I click one of the rating icons, so that I can easily open the original game when desired.
Thanks

@ttomczak3
Copy link
Contributor Author

Should this change be effective now?

I am replaying some puzzles and it is still redirecting to the dashboard as soon as I successfully replay the last puzzle in a category, without waiting for me to click the thumbs-up or thumbs-down rating buttons.

For example, at the following URL, I have one to replay.

https://lichess.org/training/replay/30/kingsideAttack

As soon as I finish replaying it, it redirects to the following page.

https://lichess.org/training/dashboard/30/dashboard

I would prefer for it to wait until I click one of the rating icons, so that I can easily open the original game when desired.

Thanks

It usually takes a bit for it to take effect after being merged.

@bill-starr
Copy link

bill-starr commented May 2, 2023

Thanks. It is working as I expect today. The replayed puzzle page does not close or redirect until after I click the green thumbs-up icon.
Edit: Sorry. Spoke too soon. It still redirects away from the last successfully-replayed puzzle page in a category before I click on the green thumbs-up icon.

@ttomczak3
Copy link
Contributor Author

Thanks. It is working as I expect today. The replayed puzzle page does not close or redirect until after I click the green thumbs-up icon.

Edit: Sorry. Spoke too soon. It still redirects away from the last successfully-replayed puzzle page in a category before I click on the green thumbs-up icon.

I asked about the schedule for updates and was told that they occur every few days, with a maximum interval of one week, depending on when the servers are restarted. There is no fixed schedule for updates.

@bill-starr-jdrweb
Copy link

Thank you, Tristen. It looks like you merged this commit on the morning of Monday, May 1. We are several hours past the expected maximum interval of one week now for that change to go live, and the site still redirects away from the last successfully-replayed puzzle in a category to the dashboard before I click on the green thumbs-up icon or the red thumbs-down icon.
An example would be the following page.
https://lichess.org/training/replay/30/fork
After I replay all of the fork puzzles that I did not previously solve correctly, it redirects back to the dashboard before I can click on one of the rating icons, or before I can open a tab to the URL of the original game.

@ttomczak3
Copy link
Contributor Author

Thank you, Tristen. It looks like you merged this commit on the morning of Monday, May 1. We are several hours past the expected maximum interval of one week now for that change to go live, and the site still redirects away from the last successfully-replayed puzzle in a category to the dashboard before I click on the green thumbs-up icon or the red thumbs-down icon. An example would be the following page. https://lichess.org/training/replay/30/fork After I replay all of the fork puzzles that I did not previously solve correctly, it redirects back to the dashboard before I can click on one of the rating icons, or before I can open a tab to the URL of the original game.

Thank you for the information, and I apologize for the inconvenience you've experienced. It appears that the changes you mentioned should have gone live by now. It seems that the website owner haven't updated their website yet. However, you can check the last time they updated the server by clicking on this link:
https://lichess.org/source#version

@benediktwerner
Copy link
Member

As you mentioned, restarts happen irregularly and with varying frequency depending on the circumstances. Usually about once a week but that's definitely not the maximum interval. 2 weeks is a more realistic expected maximum and in this case, the PR was merged shortly after the last restart.

@ttomczak3
Copy link
Contributor Author

Thanks for the update on the restarts and the expected maximum interval.

@bill-starr-jdrweb
Copy link

The fix for this issue seems to be live now. It is working as I expect. Redirects to the dashboard after last replayed puzzle in the category only after I click the green thumbs-up icon, giving me time to follow the link to the source game when I want to.
The server was last booted this morning (Fri, 12 May 2023) at 3:00 am.
https://lichess.org/source#version

@ttomczak3
Copy link
Contributor Author

It's wonderful news that the problem has been resolved, and everything is now functioning as anticipated. It appears that the new green thumbs-up icon feature is functioning smoothly and providing you with the flexibility you require. Additionally, thank you for providing information about the server boot time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Puzzle replay: redirect to dashboard only after voting
5 participants