Study - Create Chapter - Automatic orientation - check PGN player tags for user id #13362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case the orientation is set to Automatic, and if the value of the PGN tags [White "player1"] or [Black "player2"] matches the user id of the user creating the chapter, set the orientation to the matching color.
* master: (35 commits) hide ublog links in kid mode - closes lichess-org#13391 scala tweaks fix untranslated title fix css code duplication use infinite glyph New Crowdin updates (lichess-org#13302) add color field to /api/tv/channels endpoint fix: no indication that infinite analysis is on improve sound on puzzles prettier on lexicon sources move phrase edits from generated artifact to upstream source remove leftover console.log allow optional config values Fix build Domains in Vietnam Fix move-vi.json refactor: annotations on board Scalachess 15.6.5 refresh user puzzle perf after batch solve - closes lichess-org#13371 remove unused code ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the orientation is set to Automatic,
and if the value of the PGN tags
[White "player1"]or[Black "player2"]matches current user id,set the orientation to the matching color.
The specific use case which got me this idea,
was after I played a game with black pieces on another site which I happened to have the same username on,
and then imported the PGN in a study.
But maybe it is such a rare occurrence that a pasted PGN contains player tags which matches the Lichess user id,
that this change does not carry its weight - and that the user can instead manually choose the correct orientation in the Choice-box.
The dialog (no changes in dialog, just including screenshot for reference)
