Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chartjs hotfixes #13973

Merged
merged 5 commits into from Nov 12, 2023
Merged

Chartjs hotfixes #13973

merged 5 commits into from Nov 12, 2023

Conversation

allanjoseph98
Copy link
Contributor

@allanjoseph98 allanjoseph98 commented Nov 12, 2023 •
edited by kraktus

follow up of #13897

@allanjoseph98 allanjoseph98 changed the title fix charts in fromPosition games Chartjs hotfixes Nov 12, 2023
@kraktus
Copy link
Member

kraktus commented Nov 12, 2023

Thanks for the hotfixes, appreciated, I think loading animation can be removed from insights altogether too.

@ornicar
Copy link
Collaborator

ornicar commented Nov 12, 2023

thank you! sending to prod now

@ornicar ornicar merged commit 7469c22 into lichess-org:master Nov 12, 2023
3 checks passed
@allanjoseph98 allanjoseph98 mentioned this pull request Nov 13, 2023
Merged
@allanjoseph98 allanjoseph98 deleted the chartjs-hotfixes branch December 3, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@allanjoseph98 @kraktus @ornicar