New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show dates on dedicated feed page #14375
Conversation
Hey, thanks for the PR! I don't think we need the time |
Ok, shall I discard the PR then? |
No just delete the part in parens and UTC, and look at app/templating/DateHelper for examples of how to format dates without java code. |
Including HH:MM is good, sometimes there are many updates in a day and it will be weird to see three headers for the same date with nothing to differentiate them in a list. |
Actually, the changes I made only affects lichess.org/feed and not the home page
Do you mean parenthesis? Sorry for being dumb |
Yes parens is short for parentheses. Not sure about gitpod but if you ask on our discord, the guy who made our gitpod integration watches general-programming-chat and lichess-dev-onboarding pretty closely. |
|
It used to be translated to the viewer's language, now all the dates are just in english. |
So, do I need to change anything in my pr? |
DateHelper.scala to the rescue |
But what do I need to change? |
This is how it looks right now. What is the change to be done in this? Please help. |
Try showInstant instead of showEnglishInstant |
Sorry, I didn't mean to know the code change I just couldn't get what functionality needs to be changed(I didn't understand Ornicar's msg). I have now made the required changes. |
If you change your Lichess language, the date should be translated accordingly, whereas using englishinstant meant it’d always be formatted with the english style |
Show dates and times instead of time ago on dedicated feed page (lichess.org/feed) #14348