allow both 'fen' and 'user' in '#friend' URL (for the lobby) #14511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for that addition! Allowing to challenge either of the piece odds bots directly via a link already containing the suitable positions would make things a lot more convenient, especially for new challengers. |
ornicar
reviewed
Jan 20, 2024
| const forceOptions: ForceSetupOptions = {}; | ||
| const urlParams = new URLSearchParams(location.search); | ||
| const friendUser = urlParams.get('user') ?? undefined; |
There was a problem hiding this comment.
why is adding ?? undefined necessary here?
There was a problem hiding this comment.
params.get(...) returns null when the parameter is not found (i.e. string | null), but the friendUser argument of openModal a few lines below accepts string | undefined, so the null value has to be converted to undefined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is going to be useful for LeelaKnightOdds and LeelaQueenForKnight. 馃檪