New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added show eval toggle on broadcast multiboard page #14540
Conversation
I think you missed in https://github.com/lichess-org/lila/blob/master/app/views/study/jsI18n.scala |
|
Ohh, I think the translation will be added using crowdin. |
Shall I also fix #14320 in this pr? |
* master: simplify puzzle dashboard css mobile firefox doesnt support COEP credentialless 14535 - Margin Fix for Metric Buttons
* master: (40 commits) multiboard eval tick: remove unncesseray inlined style/CSS attribute Added visual indicator for showing advantage in mini-board broadcast monitor firebase data msgs separately fix push notification recipient add source field to game json export only export reports created by the player fix typos scalachess 15.7.6 Personal export: clarify that reports concerning you only include messages you posted Acpl chart: live update and spinner for studies game analysis CSP - closes lichess-org#14536 scala tweaks allow partial pull/push of broadcast round PGN show multiboard evals even if local eval is disabled - after lichess-org#14540 New Crowdin updates (lichess-org#14517) request cloud evals when toggling the option redesign multiboard options set multiboard.showEval to true by default tweak evaluation bars wording remember multiboard.showEval value using local storage ...
* master: (31 commits) game analysis CSP - closes lichess-org#14536 scala tweaks allow partial pull/push of broadcast round PGN show multiboard evals even if local eval is disabled - after lichess-org#14540 New Crowdin updates (lichess-org#14517) request cloud evals when toggling the option redesign multiboard options set multiboard.showEval to true by default tweak evaluation bars wording remember multiboard.showEval value using local storage use a toggle for multiboard showEval no need to reload multiboards, just redraw simplify puzzle dashboard css mobile firefox doesnt support COEP credentialless Removed log statement remember when bulk clock was started User.isVerifiedOrChallengeAdmin tweak bulk limits new endpoint to show a bulk export more games by ID ...
Added show eval toggle on broadcast multiboard page. This currently only shows eval if it is currently available. Should this toggle request eval if it is not available? Closes #14497
Also can you help me with ctrl.trans.noarg('Show Eval'), the playing above gets translated to other languages but this does not?