Larger title for broadcasting cards #14899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Could you include a before/after screenshot? Looks like it might be too large for desktop, particularly when applied to the normal-tier, 4-col cards. |
|
Sure. I tested it with both desktop and mobile mode. |
* master: tweak relay leaderboard caches New Crowdin updates (lichess-org#14891) numbers that can go up, must go up use relay player elo for leaderboard sorting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the cards with the large images look good at first, it may be difficult to find a tournament due to the sometimes confusing images of the tournaments. What you actually want to see are the tournament names. Larger titles improve that greatly. It also reduces the difference between large fonts in the images (large screens) and the small font of the cards.
I don't know where ".relay-cards--tier-top" is used (it looks like the top card does not use it?) but I increased that as well.