sticky topnav updates for latest PR feedback #14900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
schlawg
commented
Mar 17, 2024
schlawg
commented
- dark mode header style change
- fix for cms page margin
- account menu icon remains large, feel free to make smaller. (the reason it's kinda big is 1. to give it prominence and 2. to balance the lichess logo a bit when that's showing)
schlawg
force-pushed
the
topnav-tweaks-v2
branch
from
22b3470
to
e9a2128
Compare
* master: /broadcast title font size middle ground tweak relay leaderboard caches New Crowdin updates (lichess-org#14891) numbers that can go up, must go up use relay player elo for leaderboard sorting larger title for cards
ornicar
reviewed
Mar 18, 2024
it's okay in dasher submenus, I suppose.
|
I still have to review the TS scrupulously but I think the feature can get a try in prod. See how pissed people get. |
schlawg
commented
Mar 18, 2024
| @@ -185,7 +185,7 @@ function galleryInput(ctrl: BackgroundCtrl) { | |||
| const montageUrl = site.asset.url(gallery[`montage${cols}`], { noVersion: true }); | |||
| // our layout is static due to the single image gallery optimization. set width here | |||
| // and allow for the possibility of non-overlaid scrollbars | |||
| const width = cols * (160 + 2) + (gallery.images.length > cols * 4 ? elementScrollBarWidth() : 0); | |||
| const width = cols * (160 + 2) + (gallery.images.length > cols * 4 ? elementScrollBarWidthSlowGuess() : 0); | |||
There was a problem hiding this comment.
I guess elementScrollBarWidthSlowGuessBlameSchlawg() was too long.
…to topnav-tweaks-v2 * 'topnav-tweaks-v2' of https://github.com/schlawg/lila: commit stuff i thought i had committed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.