Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set min height for Tournament winners #14922

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

NSK07
Copy link
Contributor

@NSK07 NSK07 commented Mar 19, 2024

Set minimum height when only Tournament winners is getting displayed in the lobby screen. This will fix #14864 .Adding screenshots before and after code change for reference:
Before :
image

After :

image

@ornicar ornicar merged commit b421bf7 into lichess-org:master Mar 19, 2024
3 checks passed
@randompearl-stack
Copy link
Contributor

randompearl-stack commented Mar 19, 2024

This only fixes the tournament winners, the leaderboard div will still be missing.

when rating not shown
norating
when rating is shown
showrating

@NSK07
Copy link
Contributor Author

NSK07 commented Mar 19, 2024

@randompearl-stack when you turn off Show player ratings it is suppose to remove the leaderboard as well as other places where rating is showed. The issue is that when the leaderboard gets removed, Tournament Winners has very low space. This code is to fix the height issue.
image

@randompearl-stack
Copy link
Contributor

randompearl-stack commented Mar 19, 2024

Okay nevermind, the fix works, I thought that it would still show the leaderboard but without the players' ratings, like how the leaderboard page shows only the names of the top players.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants