use proper css for language direction #14951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: Remove chess24 (lichess-org#14962) preload the broadcast group name tweak hcaptcha skip condition better log hcaptcha result type rotate oauth token on creation - closes lichess-org#14946 Add comments for NewTree.toBranch function fixes for ios safari < 15 fix error preventing pure javascript engine when none other are available
this may be completely superfluous, but I'm concerned not all browsers are capable of optimizing `:not([dir='rtl'])` properly, so just in case I added an html class to select instead.
schlawg
commented
Mar 25, 2024
| @@ -15,10 +15,12 @@ import lila.common.base.StringUtils.escapeHtmlRaw | |||
| object layout: | |||
|
|
|||
| object bits: | |||
| val doctype = raw("<!DOCTYPE html>") | |||
| def htmlTag(using lang: Lang) = html(st.lang := lang.code, dir := isRTL.option("rtl")) | |||
There was a problem hiding this comment.
The if-rtl { } mixins are executed at most a few times per page load. Is it really a good idea to optimize away the attribute selector approach? Don't we want exactly one of if-ltr or if-rtl to always match regardless of classes? What about embeds?
There was a problem hiding this comment.
Yeah I'm not sure it's worth it. They do appear quite a lot in the CSS tho:
rg 'dir-(ltr|rtl)' lobby.dark.dev.css | wc -l
14
rg 'dir-(ltr|rtl)' round.dark.dev.css | wc -l
28
rg 'dir-(ltr|rtl)' analyse.relay.dark.dev.css | wc -l
49And more could be added, as we forget whether or not it's efficient.
* master: (184 commits) upgrade to split scalalib fix scalachess version 15.10.0 Fen.Epd -> Fen.Full upgrade scalalib & scalachess Remove unneeded path remove topnav last link border radius since group has a bottom padding define constrain alongside clamp Hopefully resolve "ResizeObserver loop limit exceeded" errors seen in user diagnostics don't trust the round finished flag remove transitive deps move unapply to common inverte common-core dependency done fix dupe streamers in menu, layout flashes use consistent boolean for showRatings and fix lichess-org#14997 Don't wrap token with single-quotes invert common->core dependency wip refactor common and core modules depend on core, not common move RawHtml move LightUser to core ...
* master: scalafmt Revert "Make Iso independent from common" Revert "Move Iso to core" Revert "Move Json to core" Move Json to core Move Iso to core Make Iso independent from common
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After taking this merge, you need to run
ui/build --update --clean-themeto get things working again.The overarching goal is to reduce the size and complexity of an asset manifest needed to support content hashing in filenames. The static themes (light, dark, and transp) will be next to go, and that PR will not be orthogonal. It will encompass and build on this one.