-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display challenge rules on the challenge page #15581
Display challenge rules on the challenge page #15581
Conversation
case GameRule.noAbort => ("Abort not allowed", Icon.X); | ||
case GameRule.noRematch => ("No rematch", Icon.InfoCircle); | ||
case GameRule.noGiveTime => ("No giving of time", Icon.Clock); | ||
case GameRule.noClaimWin => ("No claiming of win", Icon.InfoCircle); | ||
case GameRule.noEarlyDraw => ("Early draw not allowed", Icon.OneHalf); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These likely needs to be translated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually, but not in the initial PR.
You're on the right track. iconFlair(Flair("objects.hourglass-done")) |
Thanks! Now we need this |
Closes #15525.
Suggestions for better suiting icons are welcome.