Fix user profile actions hamburger icon removed on transp background #15620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ornicar
reviewed
Jun 28, 2024
| background: $c-bg-header-dropdown; | ||
| color: $c-font-clear; | ||
| box-shadow: -1px 5px 6px rgba(0, 0, 0, 0.3); |
There was a problem hiding this comment.
looks like a solution for the transparent theme, but what does it look like in light theme?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a transparent background the user profile actions hamburger icon disappears when hovered. This is due to %dropdown-shadow including the back-blur mixin if the background is transparent, which resets the ::before
content.Issue:
To keep the shadow (and icon), it seemed like the most straight-forward approach was to just include box-shadow directly instead of extending from dropdown-shadow.