Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broadcast teams: White is first #15642

Closed

Conversation

SergioGlorias
Copy link
Contributor

Screen.recording.2024-07-03.00.29.12.webm

In tournament standards the list starts with White first
as it is not directly connected to a visible tray
let's try to leave this at default

@@ -70,16 +70,17 @@ const renderTeams = (
cloudEval?: MultiCloudEval,
): MaybeVNodes =>
teams.table.map(row => {
const firstTeam = row.teams[0];
const firstTeam = row.teams[1];
const secondTeam = row.teams[0];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assumes that the second team is first, and the first team is second.
I doubt that it's always true, but if it was, then it should be fixed upstream in the backend, and not reverted in the frontend.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well... I may have done it in the frontend, but this is currently how lila is generating the teams (not just in this case at all)

Copy link
Collaborator

@ornicar ornicar Jul 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first random team broadcast I looked at has the first players using the white pieces:
https://lichess.org/broadcast/french-cup-grand-finals-chartres-2024--womens-top-12-club-championship/semi-finals/EisjcYTg#teams

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh...

@ornicar
Copy link
Collaborator

ornicar commented Jul 4, 2024

What do you mean by

as it is not directly connected to a visible tray

@SergioGlorias
Copy link
Contributor Author

What do you mean by

as it is not directly connected to a visible tray

*Visible board

In this case, I meant: when we see teams with no visible board
There shouldn't be a question of the white pieces coming first than the black pieces

@SergioGlorias
Copy link
Contributor Author

This PR needs to be reworked
No this code is not necessary

ornicar added a commit that referenced this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants