Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play sound for both forward and backward moves on the analysis board #15660

Closed
wants to merge 2 commits into from

Conversation

steptro
Copy link
Contributor

@steptro steptro commented Jul 5, 2024

I prefer having sounds for both forward and backward moves on an analysis board. Let me know what you think 🙂

@Siderite
Copy link

Siderite commented Jul 7, 2024

But... are you playing it backwards? :D That would be so cool.

@ornicar
Copy link
Collaborator

ornicar commented Jul 11, 2024

I prefer having sounds for both forward and backward moves on an analysis board. Let me know what you think 🙂

Presumably because you used another chess software that worked that way.

But many lichess users are used to the lichess analysis board, and have the opposite preference.

As you can see from the code you deleted, it was a deliberate choice:

if (isForwardStep) site.sound.move(this.node);

@ornicar ornicar closed this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants