recreate debug alerts branch #15705
Merged
recreate debug alerts branch #15705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ornicar
reviewed
Jul 12, 2024
| const cancelOnInterval = (e: PointerEvent) => { | ||
| if (Date.now() - justThen < 200) return; | ||
| const r = dialog.getBoundingClientRect(); | ||
| if (e.clientX < r.left || e.clientX > r.right || e.clientY < r.top || e.clientY > r.bottom) |
There was a problem hiding this comment.
that might conflict with (user) tooltips, select, mselect and anything adding a layer on top of the window.
There was a problem hiding this comment.
assuming they preventDefault on the click, it shouldn't arrive on the body element. If it does, I think we still want to close in that case.
I added the bounding client rect check because non-modal dialogs don't trap background clicks for us like modal ones. That said, I'm not super attached to even allowing/supporting click away for non-modals.
ornicar
reviewed
Jul 12, 2024
| @@ -74,15 +75,17 @@ export default function makeLog(): LichessLog { | |||
| }; | |||
|
|
|||
| function terseHref(): string { | |||
| return window.location.href.replace(/^(https:\/\/)?lichess\.org\//, '/'); | |||
| return window.location.href.replace(/^(https:\/\/)?lichess(?:1?)\.org\//, '/'); | |||
There was a problem hiding this comment.
I'd rather see (?:lichess|lichess1) for readability and searchability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i see the "how" argument is still in there. it's harmless for now.
i promise i'll take a hard look at cutting down the number of ways things to do things in dialog. just as soon as i arrive at a notion of the best way to do them.