Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Bugs in Profile Screen #547

Merged
merged 5 commits into from Feb 9, 2024
Merged

Fix Bugs in Profile Screen #547

merged 5 commits into from Feb 9, 2024

Conversation

HaonRekcef
Copy link
Contributor

Fixes some nasty bugs in the profile screen:

  • Currently, social media links without https or http couldn't be parsed due to the URI standard
  • I removed empty links
  • All profile text was displayed on a single line and consequently often cut off. I set the maximum to ten lines. Also it replaces all new lines with a space as its done on the website.
  • An error message with no explanation appeared when entering whitespace strings in profile editing. This fix trims leading and trailing whitespace to prevent the error.
before

before

after

after

veloce
veloce approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@veloce veloce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks! Such contributions are greatly appreciated.

@veloce veloce merged commit 921445e into lichess-org:main Feb 9, 2024
3 checks passed
@HaonRekcef HaonRekcef deleted the profile-improvements branch February 9, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veloce veloce veloce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HaonRekcef @veloce