Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

puzzle(-streak) analysis in analysisboard #610

Merged
merged 4 commits into from
Apr 11, 2024

Conversation

HaonRekcef
Copy link
Contributor

Implements #595: Allows the user to analyze the last puzzle (the one they failed) of the streak or normal puzzles on the analysis board. For streak, there is a button in the bottom bar. For normal puzzles I merged it together with the share puzzle to a menu, because we should not have two separate buttons for analysis (evaluation bar and analysis board) in the same button bar.

When the user presses to go to the analysis board the initial position corresponds to the starting position of the puzzle and the moves of the solution are there.

@veloce
Copy link
Contributor

veloce commented Mar 26, 2024

Nice!

I wonder if we should use the whole game PGN instead. As in the lichess website.

Or maybe keep it like that, but also add a button in the menu to go the the game screen of that puzzle (jumping directly to the puzzle move). What do you think?

@HaonRekcef
Copy link
Contributor Author

The puzzle API does not send the complete game, but only until the moment where the tactic happened. So for simplicity and the offline mode we should probably keep the analysis in the analysis board like this.
I agree, I can try to add a button in the menu that loads the game where the puzzle is from.

@veloce
Copy link
Contributor

veloce commented Mar 26, 2024

It does load the full game tree. But I agree let's keep the analysis as you did it. And with the game button I'll be nice!

@HaonRekcef
Copy link
Contributor Author

I added the linking to the game in the menu of the puzzle. It goes to the archived game screen of that game.
As far as I could see there is no translation for this and I called it Puzzle Source Game, maybe there is a better name for this.

Also unrelated but I improved the ordering in the puzzle themes a bit.

@veloce
Copy link
Contributor

veloce commented Mar 26, 2024

I think there is a "From game X" translation we can use.

Doesn't the ordering follow the website's one?

@HaonRekcef
Copy link
Contributor Author

Yeah, I saw that string but was not sure how to use it. "From game player1 vs player 2" will be too long.
The other option would be "From game #gameid".

No, on the website it's different as well in the meantime.

@veloce
Copy link
Contributor

veloce commented Mar 27, 2024

I'd use From game #id yes.

@HaonRekcef
Copy link
Contributor Author

done

@veloce veloce merged commit b205c13 into lichess-org:main Apr 11, 2024
3 checks passed
@HaonRekcef HaonRekcef deleted the puzzle-analysis branch April 12, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants