Broadcast - Use GridView.builder instead of ListView.builder #867
Conversation
| ); | ||
| child: Padding( | ||
| padding: Styles.bodyPadding, | ||
| child: GridView.builder( |
There was a problem hiding this comment.
The number of elements is not that large, I wonder if the GridView.count would be more appropriate? The code would be a little easier to read I think.
There was a problem hiding this comment.
I don't know how it would affect performances. According to the GridView.builder documentation the builder is called only for those children that are actually visible. From what I understand the GridView.count will create all widgets at once but it will only render them when they are visible on the screen whereas the GridView.builder will create only the widgets that are needed.
Does the number of elements that is not that large applies to the puzzles too ?
|
Looks like you based this PR on the websocket branch. You should base it on main branch so I can only review the changes related to the |
Ah I thought you would review this after the websocket PR. You can view the changes related only to the |
julien4215
force-pushed
the
broadcast/use-grid-view
branch
from
2d609cf
to
748de56
Compare
No description provided.