Treat consecutive paragraph indicators as different paragraphs #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consecutive empty lines count toward the same state, so there're 2x states (to get in and out). ^L and .PP are counted as text, hitting those in the text should be treated as getting out of a paragraph and then getting in. Closes: #118 See also: https://marc.info/?l=openbsd-bugs&m=169100763926909&w=2
|
@leres Can you review this change? Thanks. |
I was able to verify the bug and also that this change solves it. |
freebsd-git
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Aug 29, 2023
Two github issues identified the same problem:
lichray/nvi2#118
lichray/nvi2#119
For example typing "}" three times on this sample text:
.PP
1
.PP
2
.PP
3
.PP
4
.PP
5
.PP
6
moves the cursor 3 paragraphs but typing "3}" (correct) moves the
cursor 5 paragraphs ((2 * N) - 1, incorrect).
Reported by: Walter Alejandro Iglesias, Zhihao Yuan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consecutive empty lines count toward the same state, so there're 2x states (to get in and out). ^L and .PP are counted as text, hitting those in the text should be treated as getting out of a paragraph and then getting in.
Closes: #118
See also: https://marc.info/?l=openbsd-bugs&m=169100763926909&w=2