Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some netbsd related changes #3

Closed
wants to merge 3 commits into from
Closed

some netbsd related changes #3

wants to merge 3 commits into from

Conversation

yamt
Copy link
Contributor

@yamt yamt commented Mar 8, 2013

No description provided.

#define iconv_src_t const char **
#else
#define iconv_src_t char **
#endif
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we just want to eliminate the warnings, then we can do some compilation test in cmake.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we just do not want to see the warnings, then we can do some compilation test in cmake.

i agree it would be better if it's possible.
i'm not going to do it by myself because i'm not familiar with cmake, though.

YAMAMOTO Takashi

@lichray
Copy link
Owner

lichray commented Mar 8, 2013

The 'et' option does not replace the manually inserted tabs (like, just press TAB on the keyboard). Is that a desired behavior? AFAIK, vim replaces every tabs.

@yamt
Copy link
Contributor Author

yamt commented Mar 11, 2013

The 'et' option does not replace the manually inserted tabs (like, just press TAB on the keyboard). Is that a desired behavior? AFAIK, vim replaces every tabs.

it's exactly how NetBSD's nvi behaves.
because the author uses shiftwidth != tabstop.
http://mail-index.netbsd.org/tech-userlevel/2008/12/10/msg001482.html

yes, it's different from vim.

i have no strong opinion about what's a desired behaviour.

YAMAMOTO Takashi

@lichray
Copy link
Owner

lichray commented Mar 11, 2013

On Sun, Mar 10, 2013 at 10:32 PM, YAMAMOTO Takashi <notifications@github.com

wrote:

it's exactly how NetBSD's nvi behaves.
because the author uses shiftwidth != tabstop.
http://mail-index.netbsd.org/tech-userlevel/2008/12/10/msg001482.html

Well, sounds reasonable. But... 'expandtab' does not seem to be
a good name for this. Maybe... expandshift -_-

Let me see if I can make it also expand tabs.

Zhihao Yuan, ID lichray
The best way to predict the future is to invent it.


4BSD -- http://4bsd.biz/

this matters for stateful encodings like iso-2022-jp.
@yamt
Copy link
Contributor Author

yamt commented Mar 11, 2013

i pushed another patch for this branch.
yamt@01eff8a
it isn't netbsd-specific but it was easier to do within the same branch for me because
it touches the same code as the following.
yamt@9ec5eba

@lichray
Copy link
Owner

lichray commented Mar 11, 2013

On Mon, Mar 11, 2013 at 12:09 AM, YAMAMOTO Takashi <notifications@github.com

wrote:

i pushed another patch for this branch.
yamt@01eff8ahttps://github.com/yamt/nvi2/commit/01eff8a6ed6bea6f2f9b0ed07f3ff8a8eac356ba

I've heard of the problem; need some time to understand.

it isn't netbsd-specific but it was easier to do within the same branch
for me because
it touches the same code as the following.
yamt@9ec5ebahttps://github.com/yamt/nvi2/commit/9ec5eba57a0042b0432b928c918adde4128f36a9

Committed. Using a macro ICONV_TRADITIONAL given by CMake.

Zhihao Yuan, ID lichray
The best way to predict the future is to invent it.


4BSD -- http://4bsd.biz/

@yamt
Copy link
Contributor Author

yamt commented Mar 11, 2013

i pushed another patch for this branch.
yamt@01eff8ahttps://github.com/yamt/nvi2/commit/01eff8a6ed6bea6f2f9b0ed07f3ff8a8eac356ba

I've heard of the problem; need some time to understand.

basically stateful encodings like iso-2022-jp need to go back to
the initial state before EOL. otherwise the next line would
start in a wrong state.

modifying the output state is done by outputing some additional bytes
(escape sequences) which don't have a corresponding input characters.

the function in question needs to tell iconv the end of input
by calling iconv(inbuf=NULL). so that iconv outputs the above
mentioned escape sequences.

YAMAMOTO Takashi

@bentley bentley mentioned this pull request May 19, 2013
@lichray lichray force-pushed the master branch 2 times, most recently from 2c1d2dc to 9f2cc1e Compare April 3, 2015 07:23
@lichray lichray force-pushed the master branch 2 times, most recently from 834f889 to 4ee3903 Compare December 29, 2015 19:09
@lichray
Copy link
Owner

lichray commented Sep 25, 2023

Merged in 2df7421 and 5740b1c. The expandtab option is adopted since f89afc9.

@lichray lichray closed this Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants