Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes related to handleOracleReport and shares burning #636

Merged
merged 6 commits into from Feb 20, 2023
Merged

Fixes related to handleOracleReport and shares burning #636

merged 6 commits into from Feb 20, 2023

Conversation

TheDZhon
Copy link
Contributor

@TheDZhon TheDZhon commented Feb 19, 2023 •
edited

  • doc: handleOracleReport with eth_call JSON-RPC API
  • doc: burn limits
  • refactor: simulatedShareRate (and docs)
  • doc: DONT_FINALIZE_WITHDRAWALS

--

WON't fix:

  • SharesMinted event (have enough events already)

@TheDZhon TheDZhon marked this pull request as ready for review February 19, 2023 13:10
@TheDZhon TheDZhon mentioned this pull request Feb 19, 2023
Merged
26 tasks
arwer13
arwer13 approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@arwer13 arwer13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@TheDZhon TheDZhon merged commit fdbc5c1 into feature/shapella-upgrade-followups Feb 20, 2023
@TheDZhon TheDZhon deleted the fix/preliminary-audit-fixes branch February 20, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arwer13 arwer13 arwer13 approved these changes

@folkyatina folkyatina Awaiting requested review from folkyatina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TheDZhon @arwer13