Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove WCWarnBanner #141

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove WCWarnBanner #141

wants to merge 1 commit into from

Conversation

alx-khramov
Copy link
Contributor

No description provided.

@alx-khramov alx-khramov self-assigned this Jun 10, 2024
@alx-khramov alx-khramov requested a review from a team as a code owner June 10, 2024 13:41
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 10, 2024

⚠️ No Changeset found

Latest commit: c302355

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

DiRaiks
DiRaiks reviewed Jun 13, 2024
View reviewed changes
packages/connect-wallet-modal/src/connectButtons/ConnectWC.tsx
const wcUri = await getWalletConnectUri(activeConnector);
setRedirectionWindowLocation(WCURIRedirectLink, wcUri);
}
onBeforeConnect?.();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need try/catch here more?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand, this try block was only for the finally block and without catch block.
We don't need this finally block anymore, therefore we can remove the try block.

Base automatically changed from feature/si-965-update-wagmi-to-latest-stable-version-2 to main June 27, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiRaiks DiRaiks DiRaiks left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@alx-khramov alx-khramov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alx-khramov @DiRaiks