Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration file problem #13

Closed
levacic opened this issue Mar 4, 2014 · 0 comments · Fixed by #14
Closed

Configuration file problem #13

levacic opened this issue Mar 4, 2014 · 0 comments · Fixed by #14

Comments

@levacic
Copy link
Contributor

levacic commented Mar 4, 2014

The configuration file is named Config.php, but Laravel uses config.php when loading package-specific configuration files. This doesn't affect Windows users, but the configuration is completely ignored on Linux, and all settings default to falsey values (because Config::get('cron::setting') returns null, since it can't find the config file).

This also affects publishing, since artisan config:publish just copies the file from the vendor folder as-is, so it will also be copied with the wrong name.

The solution is simple - just lowercase the filename.

I'll send a pull request for this in a couple of minutes.

levacic added a commit to levacic/cron that referenced this issue Mar 4, 2014
@liebig liebig closed this as completed in #14 Mar 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant