Skip to content

Commit

Permalink
Update Python backend dependencies
Browse files Browse the repository at this point in the history
  • Loading branch information
romainthomas committed Feb 18, 2024
1 parent 78fad97 commit fe432fe
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 18 deletions.
8 changes: 0 additions & 8 deletions api/python/backend/config.py
Expand Up @@ -212,14 +212,6 @@ def get_cmake_args(self, editable: bool = False) -> List[str]:
cmake_args.append(
"-DLIEF_PYTHON_EDITABLE=ON",
)
if self._config.build.ninja:
# For some reasons, this condition is not met:
# https://github.com/scikit-build/scikit-build-core/blob/9ac2e35aa888b70e9f1999a75dfafb7a5d709f88/src/scikit_build_core/cmake.py#L173-L174
# https://github.com/scikit-build/scikit-build-core/blob/9ac2e35aa888b70e9f1999a75dfafb7a5d709f88/src/scikit_build_core/cmake.py#L205-L207
cmake_args.append(
f"-DCMAKE_BUILD_TYPE={self._config.build.build_type}",
)

return cmake_args

@property
Expand Down
5 changes: 1 addition & 4 deletions api/python/backend/setup.py
Expand Up @@ -108,10 +108,7 @@ def _get_hooked_config(is_editable: bool) -> Optional[dict[str, Union[str, List[
*config.cmake_generator,
*config.get_cmake_args(is_editable),
],
# 'wheel.exclude' does not exist but the 'wheel' is aware of it
# Note(romain): It could be worth to have a wheel.exclude for wheel.
# the directories in wheel.packages
"sdist.exclude": Config.DEFAULT_EXCLUDE,
"wheel.exclude": Config.DEFAULT_EXCLUDE,
}
return config_settings

Expand Down
12 changes: 6 additions & 6 deletions api/python/build-requirements.txt
@@ -1,12 +1,12 @@
tomli==2.0.1
scikit-build-core==0.6.0
scikit-build-core==0.8.1
# For Ninja: msvc.msvc14_get_vc_env
setuptools==68.2.2
setuptools==69.1.0
# For the "env" feature
pydantic==2.4.2
pydantic-core==2.10.1
pydantic==2.6.1
pydantic-core==2.16.2
# Implicit from scikit-build-core
pyproject_metadata==0.7.1
pathspec==0.11.2
pathspec==0.12.1
build==1.0.3
wheel==0.41.3
wheel==0.42.0

0 comments on commit fe432fe

Please sign in to comment.