Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add groups tutorial #63

Merged
merged 8 commits into from Mar 31, 2023
Merged

Add groups tutorial #63

merged 8 commits into from Mar 31, 2023

Conversation

jobrachem
Copy link
Contributor

@jobrachem jobrachem commented Mar 30, 2023 •
edited

Closes #46

Builds on #62, so that should be reviewed and merged first.

Here's a preview:

image

@jobrachem jobrachem added the comp:documentation Improvements or additions to the documentation label Mar 30, 2023
@jobrachem jobrachem requested a review from wiep March 30, 2023 14:53
@jobrachem jobrachem self-assigned this Mar 30, 2023
@jobrachem
Copy link
Contributor Author

@wiep would you do the review?

@jobrachem
Copy link
Contributor Author

I just noticed that there was an error in the very last code chunk and fixed it.

wiep
wiep approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@wiep wiep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. It looks pretty comprehensible to me. I added a few comments. Please address them as you deem appropriate and then merge the PR.

docs/source/tutorials/qmd/07-groups.qmd Show resolved Hide resolved
docs/source/tutorials/qmd/07-groups.qmd Show resolved Hide resolved
docs/source/tutorials/qmd/07-groups.qmd Show resolved Hide resolved
@jobrachem jobrachem merged commit 3e8396e into main Mar 31, 2023
3 checks passed
@jobrachem jobrachem deleted the add-groups-tutorial branch March 31, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiep wiep wiep approved these changes

Assignees

@jobrachem jobrachem

Labels
comp:documentation Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tutorial on group usage to the documentation
2 participants
@jobrachem @wiep