fix: throw on invalid URLs #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks to you. Nice trick by the way ;) |
Closed
Merged
|
@lifaon74 Hey, I think this package with this fix has not been released yet. Can you please upload the new package to npm? Thanks!!! |
zhbhun
added a commit
to zhbhun/next.js
that referenced
this pull request
May 12, 2020
…e-js/features/url url-polyfill does not throw on invalid URLs(lifaon74/url-polyfill#54). fix: [9851](vercel#9851)
|
Hi can you upload the package on npm with the fix pls? |
|
v1.1.9 released. sorry for the delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw when provided with invalid url without a base, e.g.
NB: I have only tested this manually in IE11 and Chrome 49, not sure on how to proceed with running the project's test suites. Help is very welcome
Fixes #35
Fixes #37