fix: avoid errors on IE 11 when upper case exists in base #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Chrome, when there is a subdomain in base that is upper-cased, it will return an URL that is lower-cased. In IE 11 with this polyfills, we get the error "Error: URL unable to set base <Upper-Case-URL> due to Error: <Lower-Case-Url>". This commit will make the polyfill match the behavior in Chrome (and others) by ensuring that base is always lower cased.
|
thx: v1.1.11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Chrome, when there is a subdomain in base that is upper-cased, it will return
an URL that is lower-cased. In IE 11 with this polyfills, we get the error
"Error: URL unable to set base due to Error: ".
This commit will make the polyfill match the behavior in Chrome (and others)
by ensuring that base is always lower cased.