-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing images in assets folder #399
Comments
I've also noticed missing images elsewhere e.g. on https://lifeitself.org/hubs/berlin See for comparison the old page: https://web.archive.org/web/20220520195709/https://lifeitself.us/hubs/berlin/ which has a lot more images. Aside: it also has a nice hero image - i wonder if we can work out how to do pages like that ... (that's another issue) |
@khalilcodes is there a simple way for us to extract a list of all images linked from markdown (e.g. Re fixing using the new updated script let's not do that because as you say issue with over-writing changes:
|
@khalilcodes @rufuspollock I have moved this into the next iteration. I am not sure on the status of this so maybe one of you can update accordingly 😄 |
@khalilcodes can you look at this briefly and see what status is - would be great to close this out. |
@rufuspollock running grep I can see there are quite a few images that are missing and weren't downloaded. https://web.archive.org/web/20220520195709/https://lifeitself.us doesn't seem to open at my end. Is there an archive of all images there ? |
the archive.org link was just illustrative - though i could imagine you could use it to identify the original link for missing images ... |
@rufuspollock missing Images added in PR #521. There are some broken links to images in the following pages and those could not be found. |
Re the 2 missing: were you able to them in archive.org/web versions? And can you link the archive.org/web versions of those pages that you found. |
… in jan. This PR adds all images missing in assets folder and referenced in the markdown pages. * Add all images into `content/assets/images` folder - (198 images and ~95mb)
@rufuspollock, @nathenf, @laurenwigmore I've created a list of all the image embeds lacking corresponding image files, just to be sure (see the table in the description above). I've fixed some of them but the rest is really missing. Any hints where I could find them? |
@olayway i note Khalil mentioend the november newsletter images were just missing entirely and not even on the really old wordpress site. For thos, only hope here would be looking in wayback machine. Personally, i think this issue is low priority for now. |
After using the https://github.com/flowershow/wordpress-to-markdown script to convert pages/posts to markdown files (with assets) for lifeitself migration, some pages have links to images and these are missing in
assets/images
folder.On further investigation it was found that ALL image paths including external ones like
<img src="https://i.imgur.com/OPrvrNS.png" />
were converted to relative paths![](/assets/images/OPrvrNS.png)
and downloaded toassets/images
folder. This has led to having a larger assets folder with images that were not needed locally in the first place.Main issue
Although external images are parsed to relative paths and even downloaded, some images for example from https://artearthtech.wordpress.com failed to download and therefore do not render on page.
This issue was first found for the page https://lifeitself.org/blog/2019/01/22/ken-wilber-integral-spirituality where in wordpress had images referencing to files on artearthtech.files.wordpress.com eg. https://artearthtech.files.wordpress.com/2020/03/ken-wilber-map.jpg?w=776 and was fixed for that page in commit abc765d.
Acceptance
assets/images
Tasks
assets/images
folderNotes
Status update 13 Sep 2023
Here is a list of all the image embeds that do not have a corresponding image file. Some of them just used the wrong extensions.
The text was updated successfully, but these errors were encountered: