fix(flake8): Flake8 does not support 4 letter codes anymore.

[ruler501]

See https://github.com/PyCQA/flake8/blob/main/src/flake8/plugins/finder.py#L25 for flake8 code.

I think DEL might also work

[orsinium]

Damn >.< Thank you for taking care of it. Do you know a relevant discussion for the change in flake8? I'd like to see what motivated them to break plugins again.

I'm going to take some time and think about the best error code to use now (1773-style DEA1?). And how to do backward compatibility from our side. If we change the code, the old noqa: DEAL won't work. Maybe, it's not a big deal, though.

Also, looks like we need an integration test with flake8, since they like breaking things. But don't worry, I can take care of it.

[orsinium]

What do you think about using a heterograph, like DIL? 🙃

[ruler501]

That seems to work. I think I like DEL more though. DEA1 is also good

[ruler501]

PyCQA/flake8#325 seems to be the source of our troubles. Still not sure why they chose to restrict to 3 characters.

[ruler501]

Merged your integration test in to see if everything works

[orsinium]

Make it DEL, please, and I'll be happy to merge. Meanwhile, I'll have a look if I can patch the Checker to recognize the old noqa comments. I don't want the changes to be breaking, so I'll provide a backward compatibility bridge.

[orsinium]

Looks like I have to take it from there 👀

[orsinium]

Thank you :)