Skip to content
This repository has been archived by the owner on Jan 12, 2021. It is now read-only.

Update message output #106

Closed
wants to merge 2 commits into from
Closed

Update message output #106

wants to merge 2 commits into from

Conversation

sscherfke
Copy link
Contributor

  • Adding the pylint symbol (verbal error code) makes disabling certain errors a bit easier.
  • Printing error codes in only one color makes them a bit more readable and from my experience, there is no real need to make the number stand out.

The pylint issue is more important for me. If you have any objections against the other change, I can revert it. :)

@sscherfke
Include pylint symbol in error message
47e2b75 
This makes it easier to disable a certain issue in your code.
@sscherfke
Use a single color for error codes
9f4d3d8 
This makes it easier to scan the output for messages of a certain
category (e.g., errors).  From my experience, this is more usefull than
making the number stand out.
@orsinium
Copy link
Member

Thank you! Yes, please, let's take only pylint-related changes. I don't want to rush with changing color-codes. That's a good point, I'll form a small user-group to test both outputs and see what works best 👍🏿

@orsinium orsinium mentioned this pull request Jan 11, 2021
Merged
@orsinium
Copy link
Member

I've cherry-picked and merged the pylint fix. Thank you for your help!

@sscherfke
Copy link
Contributor Author

Thank you very much. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@sscherfke @orsinium