This repository has been archived by the owner on Jan 12, 2021. It is now read-only.
fix flakehell version passed to flake8 application #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is some issue with CI, both PR I have created (2nd is #45) are really simple and all tests for them pass locally. If you know exactly what's wrong let me know I can try to fix it |
|
CI fixed in #47 |
|
Thank you, good catch 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
flakehellis using 2 versions:flakehell.__version__which is pypi package versionflakehell._constants.VERSIONwhich is passed toFlake8ApplicationasversionkwargMaybe it's some leftover after refactor or something, but it's quite confusing and imho only one version number should be used for both cases.
Please correct me if I am wrong, because maybe I misunderstood something.
Thanks for maintaining this really useful project!