This repository has been archived by the owner on Jan 12, 2021. It is now read-only.
Fix --config handling and allow --append-config #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NOTE: I'm not sure if this is supposed to work, but |
|
Commit a813cc7 now handles |
thejcannon
added a commit
to thejcannon/flakehell
that referenced
this pull request
Jul 7, 2020
|
@orsinium this should be ready for review. |
|
I'm not exactly sure what happened to this PR, or why it's closed. I'll look into it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From my testing, passing
--config ./file.tomlwasn't being handled correctly.Debugging it, it looks like
parse_preliminary_optionsinflake8strips out these options, so by the time we get to it inparse_configuration_and_clithey are nowhere to be found inargv.