Type annotations #82
Merged
Type annotations #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR introduces type annotations for everything. It's a lot of tedious manual work (despite the fact that I've bootstrapped the process with infer-types), so I might've made mistakes. If there is a type annotation that you think is wrong, contributions are welcome.
One thing to keep in mind is that the library, being one of my first projects, doesn't follow Liskov substitution principle. That means subclasses of the base class are contravariants of it. In other words, I wouldn't recommend using the base class of any algorithm as a type annotation. Also, it means that some annotations are too forgiving and aren't precise enough.