-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hot reload poc #54
Merged
Merged
hot reload poc #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ember-vite ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Code Coverage ReportCoverage after merging hot-reload-poc into master
Coverage Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo:
Try to compare by reference (original class), instead of module nameHow to check it?
Run project, edit
src/components/Button/index.ts
orsrc/components/Button/template.hbs
and see reflected changes on main page.Also, try to change
.gts
file.Upd:
Now works for all components in
/components/
folder.How it's working?
moduleName
metadata (file name) in compiled component template. Using it we map rendered components to updated.<Button .../>
to<Hot @component={{Button}} as |Button|><Button/></Hot>
Hot
component we render tracked{{yield this.component}}
and listen for related template file changes (Button
), once changed - we assign updated class tothis.component
.Button
component changed (toHot
), event contain new component class andmoduleName
(to allow it to map to any rendered component)catch emitted change events in
Hot
component!