Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add glimmer js/ts markdown language injects #45

Merged
merged 1 commit into from Jan 25, 2024

Conversation

IgnaceMaes
Copy link
Contributor

Adds support for gjs and gts embeds in Markdown.

Based on https://github.com/mjbvz/vscode-fenced-code-block-grammar-injection-example

image

Open issue: <template> tag is not picked up correctly. I did some fiddling around but haven't pinpointed the exact issue. Opening the PR already just in case anyone else sees the fix.

@IgnaceMaes
Copy link
Contributor Author

I rebased to master and with the way the merging of syntaxes has changed, I believe it fixed the issue of the <template> syntax not getting embedded into md properly.

This is the same example now:
image

And trying something a bit more challenging:
image

@IgnaceMaes IgnaceMaes marked this pull request as ready for review January 25, 2024 08:52
@lifeart lifeart merged commit fcd9712 into lifeart:master Jan 25, 2024
@lifeart
Copy link
Owner

lifeart commented Jan 25, 2024

@IgnaceMaes, thank you! Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants