-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creates the R-package structure with Best practices #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sk-sahu. Are we addressing the function names and variable names convention to snake_case
in this PR as well?
Here's a recap of what we have addressed thus far based on suggestions here:
-
usethis::create_package
was used to create the package structure (bonus: out of the boxpackagedown
) - Rename repo to lowercase only, no dashes
- lintr action added in this branch as well from b8909d3
- for functions and variable names it would be better to use
snake_case
instead ofcamelCase
this is suggested by many but here's a snippet from the Advanced R book.)
Variable and function names should be lowercase. Use an underscore () to separate words within a name. Generally, variable names should be nouns and function names should be verbs.
Thank you for the review @cgpu As I mentioned in the Note section of this PR description. We will adhere the Hope this clears the current concern. |
Hi @cgpu The new commits implements two API end points, although they are in experimental phase (tested in an abstract manner). And this complies with
Let me know if any other improvements you can suggest with this PR |
@@ -1,33 +0,0 @@ | |||
#' @title Cohort List Extractor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only function not replaced, I assume this is intended as it is depricated? Can you verify @sk-sahu. If this needs to be refactored feel free to open an issue to keep track of what's being re-implemented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this. Working at the moment. But I'll cross check again.
Also, I'l create an issue to track all up-to-date end points.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, can you check the comments and then we should be good to merge this first iteration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job @sk-sahu !
PR purpose
This creates R-package structure from scratch with usethis pkg best practices.
Adds
In addition to basic structure of R-package it adds
Note
Please ignore current existing functions. Those are old. This PR is just for the structure of R-package. Functions will be rewritten with best practices.
Thanks for the suggestions @cgpu :)