Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change default values in cb_get_participants_table #80

Merged
merged 4 commits into from
Jan 27, 2022
Merged

change default values in cb_get_participants_table #80

merged 4 commits into from
Jan 27, 2022

Conversation

ilevantis
Copy link
Contributor

This PR does the following:

  • Changes the default values for cb_get_particpants_table() to get the entire table by default.

@hms1 hms1 mentioned this pull request Jan 27, 2022
Open
hms1
hms1 approved these changes Jan 27, 2022
View reviewed changes
Copy link

@hms1 hms1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes make sense and are more logical 👍

While reviewing I noticed what looks like a bug, but I am pretty sure it's unrelated to these changes. See #81.

@ilevantis
Copy link
Contributor Author

Thanks for making the issue. We can look to fix that in a PR down the line, but it is indeed unrelated to the change in this PR.

@ilevantis ilevantis merged commit 3a28174 into devel Jan 27, 2022
@ilevantis ilevantis deleted the change_default-get_participants_table_vals branch January 27, 2022 12:09
ilevantis added a commit that referenced this pull request Feb 7, 2022
@ilevantis
change default values in cb_get_participants_table (#80)
db6c67b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hms1 hms1 hms1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ilevantis @hms1