GEL test bug fixes #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgpu
reviewed
Oct 21, 2020
cgpu
reviewed
Oct 21, 2020
cgpu
reviewed
Oct 21, 2020
cgpu
reviewed
Oct 21, 2020
| \item{page_number}{Number of page. (Optional) Default - 0} | ||
|
|
||
| \item{page_size}{Number of entries in a page. (Optional) Default - 10} | ||
| \item{size}{Number of cohort entries from database. (Optional) Default - 10} | ||
| } | ||
| \value{ | ||
| A data frame with available cohorts. |
There was a problem hiding this comment.
Below the png files (sorry for misplacing, cannot comment if binary 😄 )
are they escaping from packagedown building and need to be gitignored or we are good and keeping them for reference in the repo?
eg man/figures/README-unnamed-chunk-10-1.png
Either is fine, only checking if intended.
There was a problem hiding this comment.
We can keep them. Majority of pkgdown rendered things goes to gh-pages branch. These are used as cache.
ATM these are not big files, But on later point we can remove them.
cgpu
approved these changes
Oct 21, 2020
Closed
|
Thank you @cgpu 🙌 :) |
sk-sahu
added a commit
that referenced
this pull request
Feb 19, 2021
* base url to api server * plot color aligning with platform * readme updates with new changes * always return defualt columns untill and end point is ready from backend * refactor the dataframe creation * Unit test data modification * minor fix * updates to cohort list function * handeling null description * minor fix * value filter josn create fix * manuall josn convert with auto_unbox = F * minor fix * unit test fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements -
cb_list_cohort()for user to get the complete list along side of default 10Bug found during testing with GEL data -
NULLdescription in cohort incb_list_cohort()