Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variant: 0 #53

Closed
romainl opened this issue Oct 20, 2021 · 1 comment
Closed

Variant: 0 #53

romainl opened this issue Oct 20, 2021 · 1 comment

Comments

@romainl
Copy link

romainl commented Oct 20, 2021

The lowest supported variant is currently 2 based on the assumption that cterm* are ignored in favor of term when &t_Co <= 2. This is wrong because cterm* are definitely used when &t_Co == 2:

2c

and ignored when &t_Co < 2:

1c

Note that the behavior of 2 is generally the same as that of 8 except for these differences:

  • when using color names, red/darkred and blue/darkblue are switched, as well as yellow/darkyellow and cyan/darkcyan: ctermbg=darkred gives you whatever the terminal emulator thinks is darkblue and so on,
  • when using color indices, colors are in the standard "xterm" order: 1 is darkred, etc.

There is no difference between 1 and 0.

@lifepillar
Copy link
Owner

This is addressed by the current master. Now, Variant: 2 generates code that uses cterm attributes; Variant: 1 and Variant: 0 (now supported) generate code that uses term attributes.

@romainl romainl closed this as completed Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants