Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-124949 Ignore null results received from Sharepoint #1253

Closed
wants to merge 73 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
73 commits
Select commit Hold shift + click to select a range
4caed1d
LPS-124516 Fix alignment of info icon
naraandrade Dec 9, 2020
ae01cc4
LPS-124789 Consistency. Rename _removeCategoryParameters to _removeAs…
ruben-pulido Dec 14, 2020
8001172
LPS-124476 Check if post method for relatedSchema exists before using…
Dec 15, 2020
53135e3
LPS-124476 prep next
brianchandotcom Dec 16, 2020
f6d1255
LPS-115709 prep next
brianchandotcom Dec 16, 2020
ce2fabd
LPS-124476 LPS-115709 prep next
brianchandotcom Dec 16, 2020
a8b4951
LPS-58936 Take site/organization roles into consideration when checki…
dantewang Dec 4, 2020
f076c33
LPS-58936 Build service
dantewang Dec 7, 2020
3019407
LPS-58936 Add corresponding method to PlugsUtil
dantewang Dec 7, 2020
ec12431
LPS-58936 Apply usage. Only apply to page theme; control panel theme …
dantewang Dec 7, 2020
6bc2c8b
LPS-58936 packageinfo
dantewang Dec 7, 2020
55b83f4
LPS-58936 SF
tinatian Dec 10, 2020
9caddff
LPS-124828 If should take the default languageId value if exist
victorg1991 Dec 14, 2020
d7074ad
LPS-124828 Change content through the store instead of using innerHTM…
victorg1991 Dec 14, 2020
ba54df1
LPS-124828 Take into account language id when updading the editable v…
victorg1991 Dec 14, 2020
d337366
LPS-124828 Embed calculation inside useEffect to avoid doing it in ev…
victorg1991 Dec 14, 2020
6513822
LPS-124715 Use the correct classPK depending on the version in order …
ChrisKian Dec 10, 2020
5c24c3c
LPS-124596 use recursion to add nested fields values reference into t…
marcosapmf Dec 11, 2020
45d2f2b
LPS-124596 make sure edited will be a boolean
marcosapmf Dec 11, 2020
c352d8d
LPS-124596 keep repeatable field index since visitor index doesn't wo…
marcosapmf Dec 11, 2020
068bc63
LPS-124596 store other available languages values into dataRecordValu…
marcosapmf Dec 11, 2020
3a8d182
LPS-124596 sort var
brianchandotcom Dec 16, 2020
9654dfe
LPS-124596 make it private
brianchandotcom Dec 16, 2020
0900958
LPS-124596 fix compile, and auto SF
brianchandotcom Dec 16, 2020
c0ff643
LPS-124596 make this private too
brianchandotcom Dec 16, 2020
a904851
LPS-124596 auto SF
brianchandotcom Dec 16, 2020
10d50fc
LPS-124388 Return longs as string to avoid Js rounding problems
adolfopa Dec 14, 2020
d0e11f4
LPS-124710 Align button in Element Sets
aline-doleron Dec 11, 2020
0527c6f
LPS-124514 Each form entry has its respective version of form instance
rodrigopaulino Dec 9, 2020
0fdc059
LPS-124514 Using inner join instead of just join as requested
rodrigopaulino Dec 10, 2020
d605b14
LPS-124584 checking is remember me is marked
joseabelenda Dec 7, 2020
c443a04
LPS-124584 code review
joseabelenda Dec 10, 2020
d6feb5c
LPS-124584 proper var name
brianchandotcom Dec 16, 2020
8c9e2d4
LPS-124584 auto SF
brianchandotcom Dec 16, 2020
8c891da
LPS-124795 Fixes error when not listing nested fields for rules in Da…
matuzalemsteles Dec 11, 2020
a9c3b32
LPS-123324 Check resource for translated model and language
adolfopa Dec 15, 2020
6edeb42
LPS-121998 sql: copies add column statements to update-7.3.0-7.4.0-co…
drewbrokke Dec 11, 2020
321ac45
LPS-121998 portal-impl: removes SQL statements that were copied
drewbrokke Dec 11, 2020
f220ad8
LPS-121998 sql: copies setting default boolean values to update-7.3.0…
drewbrokke Dec 11, 2020
19eb19a
LPS-121998 portal-impl: removes copied SQL
drewbrokke Dec 11, 2020
3a3466b
LPS-121998 portal-impl: removes extra DB call
drewbrokke Dec 11, 2020
2071b51
LPS-124842 sql: quotes values since the number field of Country is a …
drewbrokke Dec 14, 2020
88b0216
LPS-121998 match service.xml
brianchandotcom Dec 16, 2020
48ace89
LPS-124591 Override form field required property with layout field re…
gabrielwas Dec 11, 2020
5aa2720
LPS-124591 SF
jeyvison Dec 15, 2020
ca0593f
LPS-124808 Only escape when necessary. This makes it so the page's ti…
jonathanmccann Dec 11, 2020
4795391
LPS-124190 Add weak reference to roleGroups
balazssk Nov 30, 2020
ed6738c
LPS-124190 as used
brianchandotcom Dec 16, 2020
43401e1
LPS-121676 Use the query filter context instead
rafaprax Dec 15, 2020
a2d7797
LPS-121676 as used in 'new UpdateByQueryDocumentRequest'
brianchandotcom Dec 16, 2020
123e93f
LPS-124948 Modify locator for card sticker
Dec 16, 2020
55b8b88
LPS-124948 Add macro to view card sticker
Dec 16, 2020
f91206e
LPS-124948 Use new macro to assert mark as default
Dec 16, 2020
918a14a
LPS-124948 Remove abandoned macro
Dec 16, 2020
5776912
LPS-124948 Modify case to view react fragment has a visual marker in …
Dec 16, 2020
b16a7f2
LPS-124948 Run case on acceptance
Dec 16, 2020
6b9c902
LPS-123926 Show -- for the accounts count for Guest account group
pei-jung Dec 16, 2020
5cd87e7
LPS-123926 Hide action menu for Guest account group
pei-jung Dec 16, 2020
7b96ad0
LPS-123926 Disable checkbox for Guest account group
pei-jung Dec 16, 2020
fd14f18
LPS-123926 Remove link on Guest account group
pei-jung Dec 16, 2020
24110fa
LPS-124751 Add properties for async support, prepare for next
tinatian Dec 15, 2020
1ef6a5d
LPS-124751 buildLang
tinatian Dec 15, 2020
123d36c
LPS-124751 Add support to process freemarker template asynchronously,…
tinatian Dec 15, 2020
c42a943
LPS-124751 Always process non-restrict template synchronously for bet…
tinatian Dec 14, 2020
af92594
LPS-124751 Force to recreate a new instance each time configuration i…
tinatian Dec 14, 2020
d866908
LPS-124751 Fix unit test
tinatian Dec 14, 2020
b9e3d3e
LPS-124751 Expose getter from base class.
shuyangzhou Dec 15, 2020
8f39c3c
LPS-124751 Move to static util
shuyangzhou Dec 15, 2020
a399c3b
LPS-124751 Enable async on ci
tinatian Dec 15, 2020
b323195
LPS-124751 Wordsmith
brianchandotcom Dec 16, 2020
fa3dd5c
LPS-124751 Sort
brianchandotcom Dec 16, 2020
012adf4
LPS-124751 Makes more sense like this
brianchandotcom Dec 16, 2020
9e0bdcb
LPS-124949 Ignore null results received from Sharepoint
adolfopa Dec 16, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions build-test.xml
Expand Up @@ -2535,6 +2535,12 @@ jdbc.default.password=${database.password}</echo>
</sequential>
</macrodef>

<macrodef name="prepare-portal-template-freemarker-osgi-configuration">
<sequential>
<echo file="${liferay.home}/osgi/configs/com.liferay.portal.template.freemarker.configuration.FreeMarkerEngineConfiguration.config">asyncRenderTimeout=L"7200000"</echo>
</sequential>
</macrodef>

<macrodef name="prepare-safari-driver">
<sequential>
<if>
Expand Down Expand Up @@ -8666,6 +8672,8 @@ osb.lcs.portlet.oauth.consumer.secret=${osb.lcs.portlet.oauth.consumer.secret}</
<prepare-portal-elasticsearch-osgi-configuration />

<prepare-portal-search-osgi-configuration/>

<prepare-portal-template-freemarker-osgi-configuration />
</target>

<target name="prepare-patching-tool">
Expand Down
10 changes: 5 additions & 5 deletions modules/.releng/sdk/gradle-plugins-defaults/artifact.properties
@@ -1,5 +1,5 @@
artifact.git.id=90aa8b8d93b5c3dbce573a9120ef53923a80f3b8
artifact.javadoc.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.gradle.plugins.defaults/7.0.7/com.liferay.gradle.plugins.defaults-7.0.7-javadoc.jar
artifact.sources-commercial.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.gradle.plugins.defaults/7.0.7/com.liferay.gradle.plugins.defaults-7.0.7-sources-commercial.jar
artifact.sources.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.gradle.plugins.defaults/7.0.7/com.liferay.gradle.plugins.defaults-7.0.7-sources.jar
artifact.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.gradle.plugins.defaults/7.0.7/com.liferay.gradle.plugins.defaults-7.0.7.jar
artifact.git.id=f6d12551216c8e7a61f44ca28425702146c6ee3b
artifact.javadoc.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.gradle.plugins.defaults/7.0.8/com.liferay.gradle.plugins.defaults-7.0.8-javadoc.jar
artifact.sources-commercial.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.gradle.plugins.defaults/7.0.8/com.liferay.gradle.plugins.defaults-7.0.8-sources-commercial.jar
artifact.sources.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.gradle.plugins.defaults/7.0.8/com.liferay.gradle.plugins.defaults-7.0.8-sources.jar
artifact.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.gradle.plugins.defaults/7.0.8/com.liferay.gradle.plugins.defaults-7.0.8.jar
@@ -1,4 +1,4 @@
artifact.git.id=dc646cc0d4a43a1f36eaf20ffd90d9194033c1bd
artifact.javadoc.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.gradle.plugins.rest.builder/1.1.16/com.liferay.gradle.plugins.rest.builder-1.1.16-javadoc.jar
artifact.sources.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.gradle.plugins.rest.builder/1.1.16/com.liferay.gradle.plugins.rest.builder-1.1.16-sources.jar
artifact.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.gradle.plugins.rest.builder/1.1.16/com.liferay.gradle.plugins.rest.builder-1.1.16.jar
artifact.git.id=80011720aaaae52986770ce4c8fb8b3c88f7ebdd
artifact.javadoc.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.gradle.plugins.rest.builder/1.1.17/com.liferay.gradle.plugins.rest.builder-1.1.17-javadoc.jar
artifact.sources.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.gradle.plugins.rest.builder/1.1.17/com.liferay.gradle.plugins.rest.builder-1.1.17-sources.jar
artifact.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.gradle.plugins.rest.builder/1.1.17/com.liferay.gradle.plugins.rest.builder-1.1.17.jar
@@ -1,4 +1,4 @@
artifact.git.id=b84297550d01e61bfea8e2d88c26ee065fa20929
artifact.javadoc.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.gradle.plugins.source.formatter/5.0.2/com.liferay.gradle.plugins.source.formatter-5.0.2-javadoc.jar
artifact.sources.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.gradle.plugins.source.formatter/5.0.2/com.liferay.gradle.plugins.source.formatter-5.0.2-sources.jar
artifact.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.gradle.plugins.source.formatter/5.0.2/com.liferay.gradle.plugins.source.formatter-5.0.2.jar
artifact.git.id=53135e307d8cc971cc64ca39775cc128e73bcf85
artifact.javadoc.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.gradle.plugins.source.formatter/5.0.3/com.liferay.gradle.plugins.source.formatter-5.0.3-javadoc.jar
artifact.sources.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.gradle.plugins.source.formatter/5.0.3/com.liferay.gradle.plugins.source.formatter-5.0.3-sources.jar
artifact.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.gradle.plugins.source.formatter/5.0.3/com.liferay.gradle.plugins.source.formatter-5.0.3.jar
10 changes: 5 additions & 5 deletions modules/.releng/sdk/gradle-plugins/artifact.properties
@@ -1,5 +1,5 @@
artifact.git.id=90aa8b8d93b5c3dbce573a9120ef53923a80f3b8
artifact.javadoc.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.gradle.plugins/13.0.3/com.liferay.gradle.plugins-13.0.3-javadoc.jar
artifact.sources-commercial.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.gradle.plugins/13.0.3/com.liferay.gradle.plugins-13.0.3-sources-commercial.jar
artifact.sources.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.gradle.plugins/13.0.3/com.liferay.gradle.plugins-13.0.3-sources.jar
artifact.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.gradle.plugins/13.0.3/com.liferay.gradle.plugins-13.0.3.jar
artifact.git.id=f6d12551216c8e7a61f44ca28425702146c6ee3b
artifact.javadoc.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.gradle.plugins/13.0.4/com.liferay.gradle.plugins-13.0.4-javadoc.jar
artifact.sources-commercial.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.gradle.plugins/13.0.4/com.liferay.gradle.plugins-13.0.4-sources-commercial.jar
artifact.sources.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.gradle.plugins/13.0.4/com.liferay.gradle.plugins-13.0.4-sources.jar
artifact.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.gradle.plugins/13.0.4/com.liferay.gradle.plugins-13.0.4.jar
@@ -1,6 +1,6 @@
artifact.git.id=dc646cc0d4a43a1f36eaf20ffd90d9194033c1bd
artifact.sources-commercial.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.portal.tools.rest.builder/1.0.141/com.liferay.portal.tools.rest.builder-1.0.141-sources-commercial.jar
artifact.sources.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.portal.tools.rest.builder/1.0.141/com.liferay.portal.tools.rest.builder-1.0.141-sources.jar
artifact.tar.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.portal.tools.rest.builder/1.0.141/com.liferay.portal.tools.rest.builder-1.0.141.tar
artifact.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.portal.tools.rest.builder/1.0.141/com.liferay.portal.tools.rest.builder-1.0.141.jar
artifact.zip.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.portal.tools.rest.builder/1.0.141/com.liferay.portal.tools.rest.builder-1.0.141.zip
artifact.git.id=80011720aaaae52986770ce4c8fb8b3c88f7ebdd
artifact.sources-commercial.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.portal.tools.rest.builder/1.0.142/com.liferay.portal.tools.rest.builder-1.0.142-sources-commercial.jar
artifact.sources.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.portal.tools.rest.builder/1.0.142/com.liferay.portal.tools.rest.builder-1.0.142-sources.jar
artifact.tar.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.portal.tools.rest.builder/1.0.142/com.liferay.portal.tools.rest.builder-1.0.142.tar
artifact.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.portal.tools.rest.builder/1.0.142/com.liferay.portal.tools.rest.builder-1.0.142.jar
artifact.zip.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.portal.tools.rest.builder/1.0.142/com.liferay.portal.tools.rest.builder-1.0.142.zip
12 changes: 6 additions & 6 deletions modules/.releng/util/source-formatter/artifact.properties
@@ -1,6 +1,6 @@
artifact.git.id=b84297550d01e61bfea8e2d88c26ee065fa20929
artifact.sources-commercial.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.source.formatter/1.0.1072/com.liferay.source.formatter-1.0.1072-sources-commercial.jar
artifact.sources.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.source.formatter/1.0.1072/com.liferay.source.formatter-1.0.1072-sources.jar
artifact.tar.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.source.formatter/1.0.1072/com.liferay.source.formatter-1.0.1072.tar
artifact.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.source.formatter/1.0.1072/com.liferay.source.formatter-1.0.1072.jar
artifact.zip.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.source.formatter/1.0.1072/com.liferay.source.formatter-1.0.1072.zip
artifact.git.id=53135e307d8cc971cc64ca39775cc128e73bcf85
artifact.sources-commercial.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.source.formatter/1.0.1073/com.liferay.source.formatter-1.0.1073-sources-commercial.jar
artifact.sources.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.source.formatter/1.0.1073/com.liferay.source.formatter-1.0.1073-sources.jar
artifact.tar.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.source.formatter/1.0.1073/com.liferay.source.formatter-1.0.1073.tar
artifact.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.source.formatter/1.0.1073/com.liferay.source.formatter-1.0.1073.jar
artifact.zip.url=https://repository-cdn.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/com.liferay.source.formatter/1.0.1073/com.liferay.source.formatter-1.0.1073.zip
Expand Up @@ -17,7 +17,6 @@
import com.liferay.account.admin.web.internal.display.AccountGroupDisplay;
import com.liferay.account.model.AccountGroup;
import com.liferay.account.service.AccountGroupLocalServiceUtil;
import com.liferay.portal.kernel.dao.search.EmptyOnClickRowChecker;
import com.liferay.portal.kernel.dao.search.SearchContainer;
import com.liferay.portal.kernel.portlet.LiferayPortletRequest;
import com.liferay.portal.kernel.portlet.LiferayPortletResponse;
Expand Down Expand Up @@ -55,7 +54,7 @@ public static SearchContainer<AccountGroupDisplay> create(
accountGroupDisplaySearchContainer.setOrderByType(orderByType);

accountGroupDisplaySearchContainer.setRowChecker(
new EmptyOnClickRowChecker(liferayPortletResponse));
new SelectAccountGroupRowChecker(liferayPortletResponse));

String keywords = ParamUtil.getString(
liferayPortletRequest, "keywords");
Expand Down
@@ -0,0 +1,38 @@
/**
* Copyright (c) 2000-present Liferay, Inc. All rights reserved.
*
* This library is free software; you can redistribute it and/or modify it under
* the terms of the GNU Lesser General Public License as published by the Free
* Software Foundation; either version 2.1 of the License, or (at your option)
* any later version.
*
* This library is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
* FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more
* details.
*/

package com.liferay.account.admin.web.internal.dao.search;

import com.liferay.account.admin.web.internal.display.AccountGroupDisplay;
import com.liferay.portal.kernel.dao.search.EmptyOnClickRowChecker;

import javax.portlet.PortletResponse;

/**
* @author Pei-Jung Lan
*/
public class SelectAccountGroupRowChecker extends EmptyOnClickRowChecker {

public SelectAccountGroupRowChecker(PortletResponse portletResponse) {
super(portletResponse);
}

@Override
public boolean isDisabled(Object object) {
AccountGroupDisplay accountGroupDisplay = (AccountGroupDisplay)object;

return accountGroupDisplay.isDefaultAccountGroup();
}

}
Expand Up @@ -37,8 +37,12 @@ public static AccountGroupDisplay of(long accountGroupId) {
AccountGroupLocalServiceUtil.fetchAccountGroup(accountGroupId));
}

public long getAccountEntriesCount() {
return _accountEntriesCount;
public String getAccountEntriesCount() {
if (_accountEntriesCount < 0) {
return StringPool.DOUBLE_DASH;
}

return String.valueOf(_accountEntriesCount);
}

public long getAccountGroupId() {
Expand All @@ -53,21 +57,31 @@ public String getName() {
return _name;
}

public boolean isDefaultAccountGroup() {
return _defaultAccountGroup;
}

private AccountGroupDisplay() {
_accountEntriesCount = 0;
_accountGroupId = 0;
_defaultAccountGroup = false;
_description = StringPool.BLANK;
_name = StringPool.BLANK;
}

private AccountGroupDisplay(AccountGroup accountGroup) {
_accountEntriesCount = _getAccountEntriesCount(accountGroup);
_accountGroupId = accountGroup.getAccountGroupId();
_defaultAccountGroup = accountGroup.isDefaultAccountGroup();
_description = accountGroup.getDescription();
_name = accountGroup.getName();
}

private long _getAccountEntriesCount(AccountGroup accountGroup) {
if (accountGroup.isDefaultAccountGroup()) {
return -1;
}

return AccountGroupAccountEntryRelLocalServiceUtil.
getAccountGroupAccountEntryRelsCountByAccountGroupId(
accountGroup.getAccountGroupId());
Expand All @@ -78,6 +92,7 @@ private long _getAccountEntriesCount(AccountGroup accountGroup) {

private final long _accountEntriesCount;
private final long _accountGroupId;
private final boolean _defaultAccountGroup;
private final String _description;
private final String _name;

Expand Down
Expand Up @@ -29,23 +29,25 @@ AccountGroupDisplay accountGroupDisplay = (AccountGroupDisplay)row.getObject();
message="<%= StringPool.BLANK %>"
showWhenSingleIcon="<%= true %>"
>
<portlet:renderURL var="editAccountGroupURL">
<portlet:param name="mvcRenderCommandName" value="/account_admin/edit_account_group" />
<portlet:param name="backURL" value="<%= currentURL %>" />
<portlet:param name="accountGroupId" value="<%= String.valueOf(accountGroupDisplay.getAccountGroupId()) %>" />
</portlet:renderURL>
<c:if test="<%= !accountGroupDisplay.isDefaultAccountGroup() %>">
<portlet:renderURL var="editAccountGroupURL">
<portlet:param name="mvcRenderCommandName" value="/account_admin/edit_account_group" />
<portlet:param name="backURL" value="<%= currentURL %>" />
<portlet:param name="accountGroupId" value="<%= String.valueOf(accountGroupDisplay.getAccountGroupId()) %>" />
</portlet:renderURL>

<liferay-ui:icon
message="edit"
url="<%= editAccountGroupURL %>"
/>
<liferay-ui:icon
message="edit"
url="<%= editAccountGroupURL %>"
/>

<portlet:actionURL name="/account_admin/delete_account_groups" var="deleteAccountGroupURL">
<portlet:param name="redirect" value="<%= currentURL %>" />
<portlet:param name="accountGroupIds" value="<%= String.valueOf(accountGroupDisplay.getAccountGroupId()) %>" />
</portlet:actionURL>
<portlet:actionURL name="/account_admin/delete_account_groups" var="deleteAccountGroupURL">
<portlet:param name="redirect" value="<%= currentURL %>" />
<portlet:param name="accountGroupIds" value="<%= String.valueOf(accountGroupDisplay.getAccountGroupId()) %>" />
</portlet:actionURL>

<liferay-ui:icon-delete
url="<%= deleteAccountGroupURL %>"
/>
<liferay-ui:icon-delete
url="<%= deleteAccountGroupURL %>"
/>
</c:if>
</liferay-ui:icon-menu>
Expand Up @@ -45,6 +45,12 @@ ViewAccountGroupsManagementToolbarDisplayContext viewAccountGroupsManagementTool
<portlet:param name="screenNavigationCategoryKey" value="<%= AccountScreenNavigationEntryConstants.CATEGORY_KEY_ACCOUNTS %>" />
</portlet:renderURL>

<%
if (accountGroupDisplay.isDefaultAccountGroup()) {
rowURL = null;
}
%>

<liferay-ui:search-container-column-text
cssClass="table-cell-expand table-title"
href="<%= rowURL %>"
Expand All @@ -63,7 +69,7 @@ ViewAccountGroupsManagementToolbarDisplayContext viewAccountGroupsManagementTool
cssClass="table-cell-expand"
href="<%= rowURL %>"
name="accounts"
value="<%= String.valueOf(accountGroupDisplay.getAccountEntriesCount()) %>"
value="<%= accountGroupDisplay.getAccountEntriesCount() %>"
/>

<liferay-ui:search-container-column-jsp
Expand Down
Expand Up @@ -55,7 +55,7 @@ public String getValue(FileEntry fileEntry, ThemeDisplay themeDisplay)
throws Exception {

JSONObject fileEntryJSONObject = JSONUtil.put(
"fileEntryId", fileEntry.getFileEntryId());
"fileEntryId", String.valueOf(fileEntry.getFileEntryId()));

String previewURL = null;

Expand Down
Expand Up @@ -77,7 +77,7 @@ public String getValue(FileEntry fileEntry, ThemeDisplay themeDisplay)
JSONObject fileEntryJSONObject = JSONUtil.put(
"defaultSource", previewURL
).put(
"fileEntryId", fileEntry.getFileEntryId()
"fileEntryId", String.valueOf(fileEntry.getFileEntryId())
);

JSONArray sourcesJSONArray = JSONFactoryUtil.createJSONArray();
Expand Down
Expand Up @@ -49,7 +49,7 @@ public String getValue(AssetEntry assetEntry, ThemeDisplay themeDisplay) {
).put(
"classNameId", assetEntry.getClassNameId()
).put(
"classPK", assetEntry.getClassPK()
"classPK", String.valueOf(assetEntry.getClassPK())
).put(
"title", assetEntry.getTitle(themeDisplay.getLocale())
).toString();
Expand Down
Expand Up @@ -51,7 +51,7 @@ public String getValue(
return JSONUtil.put(
"classNameId", _portal.getClassNameId(AssetListEntry.class)
).put(
"classPK", assetListEntry.getAssetListEntryId()
"classPK", String.valueOf(assetListEntry.getAssetListEntryId())
).put(
"title", assetListEntry.getTitle()
).toString();
Expand Down