Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-136427 Move Some Custom Properties to Clay CSS #1277

Closed
wants to merge 5 commits into from
Closed

LPS-136427 Move Some Custom Properties to Clay CSS #1277

wants to merge 5 commits into from

Commits on Jul 29, 2021

  1. LPS-136427 Leverage Clay CSS for some custom properties

    @pat270
    pat270 committed Jul 29, 2021
    Copy the full SHA
    15b151c View commit details
    Browse the repository at this point in the history

  2. LPS-136427 Classic Theme custom_properties removes duplicate CSS vari… 

    …ables definitions. Tokens inside frontend-token-definition.json are automatically generated into CSS variables inside a style tag in the head.
    @pat270
    pat270 committed Jul 29, 2021
    Copy the full SHA
    3663e57 View commit details
    Browse the repository at this point in the history

  3. LPS-136427 Classic Theme custom_properties adds gray-dark, lighter, f… 

    …ont-weight-semi-bold to token definitions, so we don't need to rewrite the CSS variables inside the theme.
    @pat270
    pat270 committed Jul 29, 2021
    Copy the full SHA
    13bbc79 View commit details
    Browse the repository at this point in the history

  4. LPS-136427 Classic Theme custom_properties removes custom properties … 

    …--transparent, --line-height-base, --line-height-sm. These are not defined in the Style Book. Line Height is also insanely difficult to customize through one variable in a giant application like DXP.
    @pat270
    pat270 committed Jul 29, 2021
    Copy the full SHA
    b2358ab View commit details
    Browse the repository at this point in the history

  5. LPS-136427 Classic Theme custom_properties clean up CSS and leverage … 

    …existing Sass variables

LPS-136427 Classic Theme SF _clay_variables.scss
    @pat270
    pat270 committed Jul 29, 2021
    Copy the full SHA
    d363d9a View commit details
    Browse the repository at this point in the history