LPS-128883 Bulk delete doesn't work on Translation Processes #1623

boton · 2021-03-15T16:14:36Z

The management toolbar actions aren't working with the TranslationManagementToolbarDefaultEventHandler.es.js and I move actions to propsTransformer.

@adolfopa please check that I am not removing something useful here 6088b14 627841e.
@carloslancha please check that I'm not doing something wrong moving to propsTransformer.

Thank you!

https://www.w3.org/TR/2011/WD-html5-20110525/elements.html#embedding-custom-non-visible-data-with-the-data-attributes

liferay-continuous-integration · 2021-03-15T16:14:39Z

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

carloslancha

LGTM

carloslancha

LGTM

...ranslation/web/internal/display/context/TranslationEntryManagementToolbarDisplayContext.java

julien

Changes in the propsTransformer LGTM

boton · 2021-03-16T14:56:51Z

ci:forward

liferay-continuous-integration · 2021-03-16T14:56:54Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

ci:test:relevant
ci:test:sf
ci:test:stable

liferay-continuous-integration · 2021-03-16T15:00:08Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 4d323e05d8ce6cbb56127da3531683f284fc26a0

Sender Branch:

Branch Name: LPS-128883-bug-translation-management-toolbar-bulk-delete
Branch GIT ID: e953b2204df838edb3a9af2ce7e281aad8f47ba7

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2021-03-16T16:25:58Z

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 21 out of 23 jobs passed in 1 hour 28 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 4d323e05d8ce6cbb56127da3531683f284fc26a0

Upstream Comparison:

Branch GIT ID: b0cce810f24b9cb02129421f0f0671dd51035591
Jenkins Build URL: Acceptance Upstream DXP (master) #1643

ci:test:stable - 9 out of 9 jobs PASSED

9 Successful Jobs:

ci:test:relevant - 20 out of 23 jobs PASSED

3 Failed Jobs:

20 Successful Jobs:

For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at b0cce81:

test-portal-acceptance-pullrequest-batch(master)/modules-unit-project-templates-jdk8/0

Job Results:

0 Tests Passed.
2 Tests Failed.

AXIS_VARIABLE=0,label_exp=!master #456751

     [exec] * What went wrong:
     [exec] Execution failed for task ':sdk:project-templates:project-templates-war-mvc-portlet:validateTLD'.
     [exec] > /opt/dev/projects/github/liferay-portal/modules/sdk/project-templates/project-templates-war-mvc-portlet/src/main/resources/archetype-resources/src/main/webapp/WEB-INF/tld/liferay-portlet-ext.tld is not a valid XML document.
     [exec] 
     [exec] * Try:
     [exec] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
     [exec] 
     [exec] * Exception is:
     [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':sdk:project-templates:project-templates-war-mvc-portlet:validateTLD'.
     [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda$executeIfValid$1(ExecuteActionsTaskExecuter.java:208)
     [exec] 	at org.gradle.internal.Try$Failure.ifSuccessfulOrElse(Try.java:263)
     [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:206)
     [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:187)
     [exec] 	at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:114)
     [exec] 	at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)
     [exec] 	at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:62)
     [exec] 	at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:57)
     [exec] 	at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:56)
     [exec] 	at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:36)
     [exec] 	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.executeTask(EventFiringTaskExecuter.java:77)
     [exec] 	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:55)
     [exec] 	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:52)

AXIS_VARIABLE=1,label_exp=!master #456751

     [exec] * What went wrong:
     [exec] Execution failed for task ':sdk:project-templates:project-templates-war-mvc-portlet:validateTLD'.
     [exec] > /opt/dev/projects/github/liferay-portal/modules/sdk/project-templates/project-templates-war-mvc-portlet/src/main/resources/archetype-resources/src/main/webapp/WEB-INF/tld/liferay-portlet-ext.tld is not a valid XML document.
     [exec] 
     [exec] * Try:
     [exec] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
     [exec] 
     [exec] * Exception is:
     [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':sdk:project-templates:project-templates-war-mvc-portlet:validateTLD'.
     [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda$executeIfValid$1(ExecuteActionsTaskExecuter.java:208)
     [exec] 	at org.gradle.internal.Try$Failure.ifSuccessfulOrElse(Try.java:263)
     [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:206)
     [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:187)
     [exec] 	at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:114)
     [exec] 	at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)
     [exec] 	at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:62)
     [exec] 	at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:57)
     [exec] 	at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:56)
     [exec] 	at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:36)
     [exec] 	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.executeTask(EventFiringTaskExecuter.java:77)
     [exec] 	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:55)
     [exec] 	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:52)

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

426 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #407927

com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError: 
com.liferay.portal.verify.VerifyException: com.liferay.commerce.currency.exception.NoSuchCurrencyException: No CommerceCurrency exists with the key {companyId=20102, code=USD}
com.liferay.portal.verify.VerifyException: com.liferay.commerce.currency.exception.NoSuchCurrencyException: No CommerceCurrency exists with the key {companyId=20102, code=USD}
	at com.liferay.portal.verify.VerifyProcess.verify(VerifyProcess.java:74)
	at com.liferay.portal.verify.extender.internal.osgi.commands.VerifyProcessTrackerOSGiCommands.executeVerifyProcesses(VerifyProcessTrackerOSGiCommands.java:294)
	at com.liferay.portal.verify.extender.internal.osgi.commands.VerifyProcessTrackerOSGiCommands$1.run(VerifyProcessTrackerOSGiCommands.java:346)
	at com.liferay.portal.output.stream.container.internal.OutputStreamContainerFactoryTrackerImpl.runWithSwappedLog(OutputStreamContainerFactoryTrackerImpl.java:134)
	at com.liferay.portal.verify.extender.internal.osgi.commands.VerifyProcessTrackerOSGiCommands.executeVerifyProcesses(VerifyProcessTrackerOSGiCommands.java:341)
	at com.liferay.portal.verify.extender.internal.osgi.commands.VerifyProcessTrackerOSGiCommands._execute(VerifyProcessTrackerOSGiCommands.java:395)
	at com.liferay.portal.verify.extender.internal.osgi.commands.VerifyProcessTrackerOSGiCommands.access$200(VerifyProcessTrackerOSGiCommands.java:80)
	at com.liferay.portal.verify.extender.internal.osgi.commands.VerifyProcessTrackerOSGiCommands$VerifyServic...

liferay-continuous-integration · 2021-03-16T16:26:11Z

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

liferay-continuous-integration · 2021-03-16T16:26:25Z

Pull request has been successfully forwarded to brianchandotcom#99959

boton added 5 commits March 15, 2021 16:29

LPS-128883 Add new propTransformer

4589c66

LPS-128883 Use hyphens for data attributes instead of camel case

3bcbdf3

https://www.w3.org/TR/2011/WD-html5-20110525/elements.html#embedding-custom-non-visible-data-with-the-data-attributes

LPS-128883 Remove old eventHandler

6088b14

LPS-128883 Remove dead code

627841e

LPS-128883 Use hyphens for data attributes instead of camel case

e953b22

https://www.w3.org/TR/2011/WD-html5-20110525/elements.html#embedding-custom-non-visible-data-with-the-data-attributes

boton changed the title ~~LPS-128883 Use hyphens for data attributes instead of camel case~~ LPS-128883 Bulk delete doesn't work on Translation Processes Mar 15, 2021

boton requested review from adolfopa and carloslancha March 15, 2021 16:23

boton added the pending review label Mar 15, 2021

carloslancha reviewed Mar 16, 2021

View reviewed changes

carloslancha approved these changes Mar 16, 2021

View reviewed changes

adolfopa reviewed Mar 16, 2021

View reviewed changes

...ranslation/web/internal/display/context/TranslationEntryManagementToolbarDisplayContext.java Show resolved Hide resolved

julien approved these changes Mar 16, 2021

View reviewed changes

adolfopa approved these changes Mar 16, 2021

View reviewed changes

boton removed the pending review label Mar 16, 2021

liferay-continuous-integration added ci:test:sf - pending ci:test:relevant - pending ci:test:stable - pending ci:test:sf - success and removed ci:test:sf - pending labels Mar 16, 2021

liferay-continuous-integration added ci:test:relevant - success ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Mar 16, 2021

liferay-continuous-integration mentioned this pull request Mar 16, 2021

LPS-128883 Bulk delete doesn't work on Translation Processes brianchandotcom/liferay-portal#99959

Closed

liferay-continuous-integration closed this Mar 16, 2021

boton deleted the LPS-128883-bug-translation-management-toolbar-bulk-delete branch January 26, 2022 13:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LPS-128883 Bulk delete doesn't work on Translation Processes #1623

LPS-128883 Bulk delete doesn't work on Translation Processes #1623

boton commented Mar 15, 2021 •

edited

liferay-continuous-integration commented Mar 15, 2021

carloslancha left a comment

carloslancha left a comment

julien left a comment

boton commented Mar 16, 2021

liferay-continuous-integration commented Mar 16, 2021

liferay-continuous-integration commented Mar 16, 2021

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Mar 16, 2021

Base Branch:

Upstream Comparison:

3 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/modules-unit-project-templates-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

liferay-continuous-integration commented Mar 16, 2021

liferay-continuous-integration commented Mar 16, 2021

LPS-128883 Bulk delete doesn't work on Translation Processes #1623

LPS-128883 Bulk delete doesn't work on Translation Processes #1623

Conversation

boton commented Mar 15, 2021 • edited

liferay-continuous-integration commented Mar 15, 2021

carloslancha left a comment

Choose a reason for hiding this comment

carloslancha left a comment

Choose a reason for hiding this comment

julien left a comment

Choose a reason for hiding this comment

boton commented Mar 16, 2021

liferay-continuous-integration commented Mar 16, 2021

liferay-continuous-integration commented Mar 16, 2021

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Mar 16, 2021

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 21 out of 23 jobs passed in 1 hour 28 minutes

Base Branch:

Upstream Comparison:

3 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/modules-unit-project-templates-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

liferay-continuous-integration commented Mar 16, 2021

liferay-continuous-integration commented Mar 16, 2021

boton commented Mar 15, 2021 •

edited