-
Notifications
You must be signed in to change notification settings - Fork 0
APIO-230 navigate to collection with server url and type of the collection #6
Conversation
this.client = new HttpClient(); | ||
this.parser = new JsonLDParser(); | ||
this.thingsCache = new Map(); | ||
this.conversionHandler = new ConversionHandler(); | ||
this.authorizationHeaders = authorizationHeaders; | ||
this.conversionHandler = new ConversionHandler(this); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like to use this around, leaks :P
src/navigator/navigator.js
Outdated
getEntryPointUrl() { | ||
const {baseUrl} = this.consumer.config; | ||
|
||
return baseUrl + '/o/api'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need the destructuring?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because... destructuring all the things!
Fixed in 98d1fb5
src/navigator/navigator.js
Outdated
} | ||
|
||
executeSteps(steps) { | ||
return steps.reduce(async (acc, step) => step(await acc), null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hehe, clever
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@p2kmgcl helped me with this :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😎
No description provided.