Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-138166 - SPIKE - Frontend performance tests for the tree filter (Subtype and Mime Type) #1667

Conversation

beltranrengifo
Copy link

@beltranrengifo beltranrengifo commented Oct 1, 2021

Jira issue
Spike documentation in Confluence

Motivation

As explained in the links above, this spike tries to document the performance of the tree component used in the Content Dashboard (view epic)

How to reproduce

To reproduce the tests used during the spike

  • Checkout to this pull request
  • Import to the Documents & Media library the fake data JSON files
  • Visit the Content Dashboard app
  • Click on Filter and Order
  • Click on Type
  • Data will show up in a modal: Inspect the modal element
  • Find the modal-body div element
  • Find the iframe element
  • Open in a new tab the iframe's src attribute

You can see now the bare component, ready for evaluation and profiling.

How to change the dataset

  • In SelectTypeAndSubtype.js component please find SELECTED_MOCK constant
  • Change its value to any of the following
    • xs
    • sm
    • md
    • lg
    • xl
    • xxl

This values refer to keys of the object mocks. You can add new values/mocks to this object if needed.

@liferay-continuous-integration

Please only forward necessary changes to Brian Chan during stabilization. Nonurgent changes should wait until the ongoing DXP 7.4 GA1 and Portal 7.4 GA4 release has been completed. For more details on the release timeline and status, see product-delivery.

@liferay-continuous-integration

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@beltranrengifo beltranrengifo changed the title LPS-138166 Using React Profiler component on Treeview inside Treefilter LPS-138166 - SPIKE - Frontend performance tests for the tree filter (Subtype and Mime Type) Oct 1, 2021
@beltranrengifo beltranrengifo added the testing 🧪 This pull request has testing code label Oct 1, 2021
@beltranrengifo
Copy link
Author

ci:close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing 🧪 This pull request has testing code
Projects
None yet
2 participants