@clayui/modal is breaking the build process (Typescript) in React 18 #4843
Labels
comp: clay-components
Issues related to Clay components. (e.g ClayCard, ClayLabel...)
type: bug
Issues reporting that Component is not doing what should be done
Milestone
Hello there 馃憢馃徎
I recently upgrade all the clay dependencies from Testray 2 React project, which Is using Typescript (CRA Template)
And also upgraded React packages too, including the latest version from React 18.0.1.
After upgrading
@types/react
and@types/react-dom
I noticed that now, React interface no longer support implicit
children
parameterClayModalProvider is showing this error message:
Probably related to: https://solverfox.dev/writing/no-implicit-children/
I could make the error desapear, using
children: ReactNode;
inside IProps TypeI can send a PR with a suggested change, to facilitate.
Thanks!
Is there an example you can provide via codesandbox.com?
I couldn't replicate the same on CodeSandBox
What are the steps to reproduce?
What is the expected result?
Shouldn't throw any error on React with Typescript
Environment
The text was updated successfully, but these errors were encountered: